merge queue: checking main (a1f510a) and #12255 together - #12267
Closed
mergify[bot] wants to merge 2 commits into
Closed
merge queue: checking main (a1f510a) and #12255 together#12267mergify[bot] wants to merge 2 commits into
mergify[bot] wants to merge 2 commits into
Conversation
The rename semantics of file-pattern scopes, `barrier_files` and the `files` /
`added-files` / `removed-files` / `modified-files` condition attributes were
written down nowhere, so the only way to learn that a rename is treated as a
removal at the source plus an addition at the destination was to try it.
Document the rule where each surface is described, with the `git mv` example
spelled out attribute by attribute, and note that `#files` is GitHub's own
changed-file count and so does not equal the length of `files` on a pull
request containing a rename.
While verifying the rename example against the engine's actual glob matcher, two
things turned out to be wrong on this page and are fixed here too:
- the rename example used `git mv api/auth.py web/auth.py`, but `web/auth.py` matches
none of the `frontend` patterns (they are `.js`/`.jsx`/`.ts`/`.tsx`), so it reported
one scope, not both;
- the multi-language example declared `apps/web/**/*.{js,jsx,ts,tsx}`. Brace expansion
is not supported by the matcher, so that pattern matched nothing and the `frontend`
scope in that example could never fire. Expanded into one pattern per extension.
Related to MRGFY-8248
Change-Id: I6cda667056c5aef19df77caace5438d458b92c7a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 This pull request has been checked successfully and will be merged soon. 🎉
Branch main (a1f510a) and #12255 are queued together for merge.
This pull request has been created by Mergify to check the mergeability of #12255.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.
Required conditions of queue rule
defaultfor merge:github-review-approved[🛡 GitHub repository ruleset ruleRequire pull request for default branch]schedule=Mon-Fri 09:00-17:30[Europe/Paris]Enforce conventional commit]:title ~= ^(fix|feat|internal|docs|style|refactor|perf|test|build|ci|chore|revert|ui)(?:\(.+\))?!?:👀 Review Requirements]:#approved-reviews-by >= 2author = dependabot[bot]author = mergify-ci-bot📕 PR description]:body ~= (?ms:.{48,})🔎 Reviews]:#changes-requested-reviews-by = 0#review-requested = 0#review-threads-unresolved = 0🤖 Continuous Integration]:check-success = buildcheck-success = lintcheck-success = testcheck-success = test-broken-linkslabel = ignore-broken-linkscheck-success=Cloudflare Pages-head-repo-full-name~=^Mergifyio/Required conditions to stay in the queue:
author != dependabot[bot]author != mergify-ci-botgithub-review-approved[🛡 GitHub repository ruleset ruleRequire pull request for default branch]Enforce conventional commit]:title ~= ^(fix|feat|internal|docs|style|refactor|perf|test|build|ci|chore|revert|ui)(?:\(.+\))?!?:👀 Review Requirements]:#approved-reviews-by >= 2author = dependabot[bot]author = mergify-ci-bot📕 PR description]:body ~= (?ms:.{48,})🔎 Reviews]:#changes-requested-reviews-by = 0#review-requested = 0#review-threads-unresolved = 0🤖 Continuous Integration]:check-success = buildcheck-success = lintcheck-success = testcheck-success = test-broken-linkslabel = ignore-broken-linkscheck-success=Cloudflare Pages-head-repo-full-name~=^Mergifyio/