Skip to content

merge queue: checking main (a1f510a) and #12255 together - #12267

Closed
mergify[bot] wants to merge 2 commits into
mainfrom
mergify/merge-queue/f0640f57b5
Closed

merge queue: checking main (a1f510a) and #12255 together#12267
mergify[bot] wants to merge 2 commits into
mainfrom
mergify/merge-queue/f0640f57b5

Conversation

@mergify

@mergify mergify Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

🎉 This pull request has been checked successfully and will be merged soon. 🎉

Branch main (a1f510a) and #12255 are queued together for merge.

This pull request has been created by Mergify to check the mergeability of #12255.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.

Required conditions of queue rule default for merge:

Required conditions to stay in the queue:

---
checking_base_sha: a1f510adeb478e68a58b498979b4550dce994eb4
previous_check_retries: []
previous_failed_batches: []
pull_requests:
  - number: 12255
    scopes: []
scopes: []
...

sileht and others added 2 commits July 30, 2026 11:24
The rename semantics of file-pattern scopes, `barrier_files` and the `files` /
`added-files` / `removed-files` / `modified-files` condition attributes were
written down nowhere, so the only way to learn that a rename is treated as a
removal at the source plus an addition at the destination was to try it.

Document the rule where each surface is described, with the `git mv` example
spelled out attribute by attribute, and note that `#files` is GitHub's own
changed-file count and so does not equal the length of `files` on a pull
request containing a rename.

While verifying the rename example against the engine's actual glob matcher, two
things turned out to be wrong on this page and are fixed here too:

- the rename example used `git mv api/auth.py web/auth.py`, but `web/auth.py` matches
  none of the `frontend` patterns (they are `.js`/`.jsx`/`.ts`/`.tsx`), so it reported
  one scope, not both;
- the multi-language example declared `apps/web/**/*.{js,jsx,ts,tsx}`. Brace expansion
  is not supported by the matcher, so that pattern matched nothing and the `frontend`
  scope in that example could never fire. Expanded into one pattern per extension.

Related to MRGFY-8248

Change-Id: I6cda667056c5aef19df77caace5438d458b92c7a
@mergify
mergify Bot deployed to Mergify Merge Protections July 30, 2026 09:45 Active
@mergify mergify Bot closed this Jul 30, 2026
@mergify
mergify Bot deleted the mergify/merge-queue/f0640f57b5 branch July 30, 2026 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant