fix(404): restore the navbar logo on the 404 page#11661
Merged
mergify[bot] merged 1 commit intoMay 27, 2026
Merged
Conversation
The 404 page renders `<Header />` without a `<LeftSidebar />`, but the
docs Header CSS assumes a sidebar exists at >=50em:
- `header { left: var(--theme-left-sidebar-width); }` shifts the navbar
right, leaving a 17rem empty gap on the left of the 404 navbar
- `.logo-mobile { display: none; }` hides the in-header logo on the
assumption that the sidebar's own logo takes over — but the sidebar
isn't there, so the 404 page renders with no logo at all
Override both rules on the 404 page so the header sits flush with the
viewport edge and the mobile-style logo stays visible at all widths.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Change-Id: I564d279c3dd61fc810b96c0a28740ca5f4dcd940
Contributor
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 🤖 Continuous IntegrationWonderful, this rule succeeded.
🟢 👀 Review RequirementsWonderful, this rule succeeded.
🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 🔎 ReviewsWonderful, this rule succeeded.
🟢 📕 PR descriptionWonderful, this rule succeeded.
|
There was a problem hiding this comment.
Pull request overview
Adjusts the 404 page styling to account for the fact that it renders the global Header without the docs LeftSidebar, ensuring the header isn’t offset and the logo remains visible on wide viewports.
Changes:
- Override the header’s desktop
leftoffset on the 404 page to keep the navbar flush with the viewport. - Override the desktop rule that hides
.logo-mobileso the in-header logo stays visible on the 404 page.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kozlek
approved these changes
May 27, 2026
JulianMaurin
approved these changes
May 27, 2026
Contributor
Merge Queue Status
This pull request spent 6 minutes in the queue, including 4 minutes 42 seconds running CI. Required conditions to merge
|
51 tasks
mergify
Bot
deleted the
devs/jd/fix/404-page-layout/restore-navbar-logo-404-page--564d279c
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 404 page renders
<Header />without a<LeftSidebar />, but thedocs Header CSS assumes a sidebar exists at >=50em:
header { left: var(--theme-left-sidebar-width); }shifts the navbarright, leaving a 17rem empty gap on the left of the 404 navbar
.logo-mobile { display: none; }hides the in-header logo on theassumption that the sidebar's own logo takes over — but the sidebar
isn't there, so the 404 page renders with no logo at all
Override both rules on the 404 page so the header sits flush with the
viewport edge and the mobile-style logo stays visible at all widths.
Co-Authored-By: Claude Opus 4.7 noreply@anthropic.com