fix layout of posts on startpage if combined mode is used#2020
Merged
blued-gear merged 10 commits intomainfrom Mar 3, 2026
Merged
fix layout of posts on startpage if combined mode is used#2020blued-gear merged 10 commits intomainfrom
blued-gear merged 10 commits intomainfrom
Conversation
Co-authored-by: BentiGorlich <benjamin_g@posteo.de>
BentiGorlich
previously approved these changes
Feb 18, 2026
…_again_again' into fix/combined_post-vote_btn-again_again_again
Member
|
Yeah I think we should remove it 🤔
Am 20. Februar 2026 22:11:25 MEZ schrieb blued_gear ***@***.***>:
…
@blued-gear commented on this pull request.
> @@ -437,7 +438,7 @@ export default class extends Controller {
}
isOnCombined() {
- return location.pathname.endsWith('/combined') || location.pathname.includes('/combined/');
+ return this.forceCombinedValue || location.pathname.endsWith('/combined') || location.pathname.includes('/combined/');
Not really, but if the component is ever used outside the `subject`template, it is useful again. And the check is short-circuited, so there is no impact in leaving it in. \
But in such a case the issue with taking the mode form criteria stays, so I can remove the path check if you wish.
--
Reply to this email directly or view it on GitHub:
#2020 (comment)
You are receiving this because your review was requested.
Message ID: ***@***.***>
|
BentiGorlich
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.