fix ode-energy-sample and clean/fix librr stuff#361
Closed
drbergman wants to merge 2 commits intoMathCancer:developmentfrom
Closed
fix ode-energy-sample and clean/fix librr stuff#361drbergman wants to merge 2 commits intoMathCancer:developmentfrom
drbergman wants to merge 2 commits intoMathCancer:developmentfrom
Conversation
- introduce `update_time_step` in `RoadRunnerIntracellular`
- set for each instance of `RoadRunnerIntracellular`
- this controls the timestep for the model
- will be set to `intracellular_dt` if not specified in the xml for the given cell type
- add the `intracellular_dt` element as a child of the `intracellular` element in the xml
- could be set on a cell-by-cell basis if desired
- introduce `previous_update_time` in `RoadRunnerIntracellular`
- tracks the previous update time
- used to determine how long to run the ODE when updating
- set to `current_time` when copying/cloning
- fix `next_librr_run` in `RoadRunnerIntracellular`
- was not being updated and thus ODE models were running at every time step
- check `current_time >= next_librr_run - 0.5 * diffusion_dt` to determine if an update is needed
- cleaned up librr files
- fixed and cleand ode-energy-sample
- it was running the intracellular models in `main.cpp` and in the update cells function
- it seemed to try to set intracellular_dt inside the intracellular element of the xml
- messy custom.cpp and custom.h
before, only new ones were validated. those "copied" from previously read defs were not Presumably, it was assumed that they fully inherited their parent's model, but as of now, they read the xml to get their model, so they need to be validated.
Collaborator
Author
|
See PR #362 for a better update to the libRR api. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update [25-02-13]: See PR #362 for a better update to the libRR api.
update_time_stepinRoadRunnerIntracellularRoadRunnerIntracellularintracellular_dtif not specified in the xml for the given cell typeintracellular_dtelement as a child of theintracellularelement in the xmlprevious_update_timeinRoadRunnerIntracellularcurrent_timewhen copying/cloningnext_librr_runinRoadRunnerIntracellularcurrent_time >= next_librr_run - 0.5 * diffusion_dtto determine if an update is neededcurrent_time + update_time_stepwhen copying/cloningmain.cppand in the update cells function