fix(helm): configurable imagePullPolicy and task polling defaults - #265
Open
CL-SHLOMIKONCHA wants to merge 1 commit into
Open
fix(helm): configurable imagePullPolicy and task polling defaults#265CL-SHLOMIKONCHA wants to merge 1 commit into
CL-SHLOMIKONCHA wants to merge 1 commit into
Conversation
- add a top-level imagePullPolicy value (default IfNotPresent) and use it in the deployment instead of the hardcoded Always - default TASK.pollingTime and heartbeat.intervalMs to 3000, matching the raster-export and raster-ingestion umbrella overrides - default mclabels.prometheus.port to 9500, the port the service exposes metrics on Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues: MAPCO-11633, raster-export / raster-ingestion umbrella TODOs (
helm-charts-new→charts/raster-export/values.yaml,charts/raster-ingestion/values.yaml), site-valuesraster/export/*.yaml,raster/ingestion/*.yamlFurther information:
Default values
imagePullPolicyAlwaysin the deploymentIfNotPresentenv.TASK.pollingTime10003000env.heartbeat.intervalMs3003000mclabels.prometheus.port80809500(the portenv.metrics.portexposes)The deployment now renders
imagePullPolicy: {{ .Values.imagePullPolicy }}, so the umbrella and site-values TODOs "no image pull policy set for this container inside service" are resolved: consumers can setimagePullPolicylike the other raster charts (top-level key, same as exporter-trigger and polygon-parts-manager).Consumer lines that can be dropped once this ships
exporter-gpkg-merger.env.TASK.pollingTime,exporter-gpkg-merger.env.heartbeat.intervalMsand the "image pull policy hardcoded" TODO comment.gpkg-merger.mclabels.prometheus.port,gpkg-merger.env.TASK.pollingTime,gpkg-merger.env.heartbeat.intervalMs.raster/export/{dev,qa}.yamlandraster/ingestion/{dev,qa}.yamlTODO comments under the gpkg-merger blocks.Not changed:
MergerService/appsettings.jsonstill haspollingTime: 1000andintervalMs: 300for local runs; the chart values override them in deployments.🤖 Generated with Claude Code