Create Mesh Gen Landice Test Case for Uummannaq/Disko Bay#911
Open
alexolinhager wants to merge 14 commits intoMPAS-Dev:mainfrom
Open
Create Mesh Gen Landice Test Case for Uummannaq/Disko Bay#911alexolinhager wants to merge 14 commits intoMPAS-Dev:mainfrom
alexolinhager wants to merge 14 commits intoMPAS-Dev:mainfrom
Conversation
trhille
reviewed
Aug 18, 2025
| # distance from ice margin to cull (km). | ||
| # Set to a value <= 0 if you do not want | ||
| # to cull based on distance from margin. | ||
| cull_distance = -.0 |
alexolinhager
force-pushed
the
create_uummannaq_disko
branch
from
19bd7d5 to
9fe92a5
Compare
alexolinhager
force-pushed
the
create_uummannaq_disko
branch
from
52fbe2d to
864d0c5
Compare
Creates the option to maintain resolution in the ocean. Used to resolve fjords and bathymetry when coupling to MPAS-Ocean.
This commit creates the option to maintain high resolution in all ocean cells (same resolution as what is prescribed at outlet glacier termini). This is necessary to resolve the fjord geometry that thermal forcing parameterizations rely on. To reduce time when generating these higher resolution meshes, this commit also introduces an option to do an initial cull of the bedMachine dataset using the extent of the contintental shelf before generating the GIS mesh.
This commit moves the calculation of geom_points and geom_edges using a geojson of the gis contintental shelf extent to compass/landice/tests/greenland/mesh.py, instead of compass/landice/mesh.py. If this options is not being used, thn geom_points and geom_edges are calculated within build_cell_width, as per usual
Co-authored-by: Trevor Hillebrand <trhille@lanl.gov>
Re-introduces code that sets a large cell width for cells that will be culled by distance from ice edge. Only applied when not using a geojson to pre-cull domain
Ensures the bedTopography constraint on mesh resolution is enforced regardless 'max_res_in_ocn'. Instead, grid resolution in the ocean is maximized following the bedTopgraphy constraint, overwritting it where necessary.
Introduces new landice test case to generate a domain for the Uummannaq/Disko Bay region of GIS.
Create region masks for each tidewater outlet glacier in domain
Addresses bug introduced by the inclusion of the parallel_executable argument in interp_gridded2mali
Adds surface and basal mass balances fields and their respective uncertainties to the uummmannaq/disko mesh_gen test case. used for the dhdt albany optimization
alexolinhager
force-pushed
the
create_uummannaq_disko
branch
from
864d0c5 to
6fedb76
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creates a new landice test case to generate a mesh for the Uummannaq Bay/Disko Bay region of GIS. Default
.cfgfile usesmax_res_in_ocncapability fromhttps://github.com/MPAS-Dev/compass/pull/894, so should be merged afterwards.Checklist
api.rst) has any new or modified class, method and/or functions listedE3SM-Projectsubmodule has been updated with relevant E3SM changesMALI-Devsubmodule has been updated with relevant MALI changesTestingin this PR) any testing that was used to verify the changes