Skip to content

Fix hypoelastic probe output - #1721

Open
ChrisZYJ wants to merge 1 commit into
MFlowCode:masterfrom
ChrisZYJ:fix_elastic_probe
Open

Fix hypoelastic probe output#1721
ChrisZYJ wants to merge 1 commit into
MFlowCode:masterfrom
ChrisZYJ:fix_elastic_probe

Conversation

@ChrisZYJ

Copy link
Copy Markdown
Contributor

Description

  • Bug fix

Fix hypoelastic probe output (tau_e):
Previously 1D probes drop the computed tau_e(1), 3D probes contain no stress, and the probe sound speed is acoustic-only

Testing

Passed local tests.

Checklist

Check these like this [x] to indicate which of the below applies.

  • I added or updated tests for new behavior
  • I updated documentation if user-facing behavior changed

See the developer guide for full coding standards.

GPU changes (expand if you modified src/simulation/)
  • GPU results match CPU results
  • Tested on NVIDIA GPU or AMD GPU

AI code reviews

Reviews are not retriggered automatically. To request a review, comment on the PR:

  • @claude full review — Claude full review (also triggers on PR open/reopen/ready)
  • Or add label claude-full-review — Claude full review via label

@ChrisZYJ
ChrisZYJ requested a review from sbryngelson as a code owner August 11, 2026 08:17
@codecov

codecov Bot commented Aug 11, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.18%. Comparing base (ae4b4c4) to head (6fe3f34).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/simulation/m_data_output.fpp 0.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1721      +/-   ##
==========================================
- Coverage   61.21%   61.18%   -0.04%     
==========================================
  Files          84       84              
  Lines       21601    21612      +11     
  Branches     3195     3200       +5     
==========================================
  Hits        13223    13223              
- Misses       6209     6220      +11     
  Partials     2169     2169              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant