fix: convergence tests leak into --only <label> runs#1438
Merged
sbryngelson merged 1 commit intoMay 15, 2026
Merged
Conversation
When the user passes --only 2D (or any non-Convergence label),
_filter_only keeps convergence cases whose traces contain that
label (e.g. 'Convergence -> 2D -> WENO5'). The previous skip
guard 'if not ARG(only)' was then bypassed because ARG('only')
was non-empty, so those convergence cases were executed.
Fix: apply the convergence skip whenever --list is not set,
regardless of whether --only was given. Only bypass the skip when
the user explicitly names 'Convergence' in the --only labels or
supplies a specific convergence-case UUID.
Contributor
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1438 +/- ##
=======================================
Coverage 65.00% 65.00%
=======================================
Files 72 72
Lines 18810 18810
Branches 1553 1555 +2
=======================================
Hits 12227 12227
Misses 5615 5615
Partials 968 968 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--only 2D(or any non-Convergencelabel) was accidentally running convergence cases whose traces contained that label — e.g.Convergence -> 2D -> WENO5would be selected by--only 2D, and the previous skip guard (if not ARG("only")) was bypassed becauseARG("only")was non-empty.--listis set, regardless of whether--onlywas given. Convergence cases are only included when the user explicitly passesConvergenceas a label or supplies a specific convergence-case UUID.Test plan
./mfc.sh test --dry-run --only 2D→ 223 tests, no convergence cases./mfc.sh test --dry-run --only Convergence→ 32 convergence tests./mfc.sh test --dry-run --only Convergence 2D→ 7 tests (explicit 2D convergence opt-in still works)./mfc.sh test --dry-run(default) → 578 tests, no convergence cases./mfc.sh precheckpasses (all 6 checks)