Skip to content

refactor: consolidate grid, stretch, and body force params into derived types #1432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sbryngelson wants to merge 46 commits into
base: master
Choose a base branch
from

Merge branch 'master' into refactor/derived-types

86f9cd1
Select commit
Loading
Failed to load commit list.
Open

refactor: consolidate grid, stretch, and body force params into derived types #1432

Merge branch 'master' into refactor/derived-types
86f9cd1
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 20, 2026 in 1s

60.96% (target 1.00%)

View this Pull Request on Codecov

60.96% (target 1.00%)

Details

Codecov Report

❌ Patch coverage is 58.07823% with 493 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.96%. Comparing base (ab146e9) to head (86f9cd1).

Files with missing lines Patch % Lines
src/simulation/m_cbc.fpp 50.00% 55 Missing and 15 partials ⚠️
src/common/m_boundary_common.fpp 55.92% 22 Missing and 45 partials ⚠️
src/simulation/m_bubbles_EL.fpp 30.61% 33 Missing and 1 partial ⚠️
src/post_process/m_data_output.fpp 41.81% 32 Missing ⚠️
src/pre_process/m_icpp_patches.fpp 31.91% 31 Missing and 1 partial ⚠️
src/pre_process/m_start_up.fpp 40.00% 19 Missing and 5 partials ⚠️
src/common/m_mpi_common.fpp 30.30% 15 Missing and 8 partials ⚠️
src/simulation/m_data_output.fpp 45.94% 19 Missing and 1 partial ⚠️
src/common/m_chemistry.fpp 65.38% 18 Missing ⚠️
src/simulation/m_bubbles_EL_kernels.fpp 32.00% 14 Missing and 3 partials ⚠️
... and 22 more
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1432      +/-   ##
==========================================
- Coverage   61.31%   60.96%   -0.35%     
==========================================
  Files          72       72              
  Lines       19771    19687      -84     
  Branches     2852     2856       +4     
==========================================
- Hits        12123    12003     -120     
- Misses       5699     5743      +44     
+ Partials     1949     1941       -8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov