Open
Conversation
Lokathor
reviewed
Feb 18, 2026
Owner
|
This CI fail is an msrv problem. I think our msrv policy is "Stable-20", so that's 1.72 currently. I forget when mutable refs in const fns was allowed, but we could make the fn not be const if necessary. |
Owner
|
Or we could make it feature gated, that works too! |
Author
Sorry, just saw this after already pushing the change you suggested. Give me a sec, I'll revert back to the feature-gated version. |
Owner
|
Using older than the current stable rust is kinda "theoretical", so it's fine either way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.