Skip to content

feat(windows): add keyboard/mouse support and expose global UMDF control-device path#34

Open
ReenigneArcher wants to merge 2 commits into
masterfrom
fix/missing-compat
Open

feat(windows): add keyboard/mouse support and expose global UMDF control-device path#34
ReenigneArcher wants to merge 2 commits into
masterfrom
fix/missing-compat

Conversation

@ReenigneArcher

Copy link
Copy Markdown
Member

Description

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

Implement keyboard and mouse input through Win32 SendInput API. The keyboard backend supports individual key events and Unicode text input. The mouse backend supports relative/absolute motion, button events (including XButtons), and both vertical and horizontal scrolling with high-resolution support. Gamepad input continues to use the UMDF driver for descriptor-driven virtual devices. Update documentation, capabilities reporting, and tests accordingly.
Windows control channel discovery now supports both `\\.\LibVirtualHid` and `\\.\Global\LibVirtualHid` by default, while still honoring `LIBVIRTUALHID_WINDOWS_CONTROL_DEVICE` as an explicit override. The UMDF driver now creates the global symbolic link first and also attempts the legacy non-global link for compatibility. Protocol constants and unit/fixture tests were updated to cover the new global path behavior.
@sonarqubecloud

sonarqubecloud Bot commented Jul 1, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
2 New issues
2 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@codecov

codecov Bot commented Jul 1, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 26.66667% with 110 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.47%. Comparing base (0d704b0) to head (5bcb49e).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/platform/windows/windows_backend.cpp 26.66% 109 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #34      +/-   ##
==========================================
- Coverage   87.70%   85.47%   -2.23%     
==========================================
  Files          14       14              
  Lines        4091     4228     +137     
  Branches     1390     1436      +46     
==========================================
+ Hits         3588     3614      +26     
- Misses        388      496     +108     
- Partials      115      118       +3     
Flag Coverage Δ
Linux-Clang 71.34% <ø> (ø)
Linux-GCC 83.41% <ø> (ø)
Windows-MSVC 84.26% <28.68%> (-3.35%) ⬇️
Windows-MinGW-UCRT64 75.72% <20.58%> (-3.87%) ⬇️
macOS 70.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/platform/windows/control_protocol.hpp 100.00% <ø> (ø)
src/platform/windows/windows_backend.cpp 58.36% <26.66%> (-15.24%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d704b0...5bcb49e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant