chore: use lizardbyte-common in c++#30
Merged
Merged
Conversation
Replace local GoogleTest fixture implementations with `lizardbyte-common` testing support. The tests CMake now enables and links `lizardbyte::test_support`, adds the submodule when needed, and fails fast if required targets are missing. This removes duplicated fixture code in `tests/fixtures` and centralizes shared test behavior in the common submodule.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #30 +/- ##
=======================================
Coverage 87.70% 87.70%
=======================================
Files 14 14
Lines 4091 4091
Branches 1390 1390
=======================================
Hits 3588 3588
+ Misses 381 366 -15
- Partials 122 137 +15
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Harness.
|
Bumps `third-party/lizardbyte-common` from commit `0fcde42` to `d219f38` to pull in upstream changes from the shared common library.
Updates the `third-party/lizardbyte-common` submodule reference from `d219f38` to `60bf936` to pull in the latest upstream changes.
Update the `third-party/lizardbyte-common` submodule pointer from `60bf936` to `3f29834` to pull in the latest upstream shared changes.
38 tasks
Updates the README with centered branding, status badges, and a short overview section. Adds a JetBrains run configuration for opening the generated documentation locally.
ReenigneArcher
force-pushed
the
chore/use-lizardbyte-common-in-c++
branch
from
144dbbe to
d649aee
Compare
Drops the Read the Docs badge from the README header badges and updates the `third-party/lizardbyte-common` submodule to commit `49aa8c6`.
Updates the `third-party/lizardbyte-common` submodule reference from `49aa8c6` to `06cd442` to pull in the latest upstream common-library changes.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use lizardbyte-common helpers. Also updates readme per LizardByte/roadmap#168.
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage