Skip to content

fix(linux): migrate to qt tray#4907

Draft
ReenigneArcher wants to merge 3 commits intomasterfrom
fix/linux/migrate-to-qt-tray
Draft

fix(linux): migrate to qt tray#4907
ReenigneArcher wants to merge 3 commits intomasterfrom
fix/linux/migrate-to-qt-tray

Conversation

@ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented Mar 24, 2026

Description

Migrates system tray library on Linux to use Qt version, from LizardByte/tray#104

TODO:

  • clicking pair notification does not open Sunshine config ui
  • left clicking tray icon does not bring up menu (double click works)
  • menu opens near top left of screen on Wayland, okay on Xorg
  • cannot dismiss menu by clicking outside of it on Xorg, okay on Wayland (esc key allows dismissing in Xorg)
  • KDE Plasma's settings for tray icon visibility don't allow changing the tray icon visibility
  • Using Qt6, icon is not setup properly (uses generic ... replacement)

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@codecov
Copy link

codecov bot commented Mar 24, 2026

Bundle Report

Bundle size has no change ✅

@ReenigneArcher ReenigneArcher force-pushed the fix/linux/migrate-to-qt-tray branch 10 times, most recently from f4eceff to 73ec9c7 Compare March 25, 2026 03:37
@codecov
Copy link

codecov bot commented Mar 25, 2026

Codecov Report

❌ Patch coverage is 8.69565% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 18.14%. Comparing base (3fb10a0) to head (cfec362).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/system_tray.cpp 8.69% 6 Missing and 15 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4907      +/-   ##
==========================================
- Coverage   18.22%   18.14%   -0.09%     
==========================================
  Files         105      105              
  Lines       21939    21951      +12     
  Branches     9818     9839      +21     
==========================================
- Hits         3999     3983      -16     
- Misses      16012    16453     +441     
+ Partials     1928     1515     -413     
Flag Coverage Δ
Archlinux 12.19% <0.00%> (-0.02%) ⬇️
FreeBSD-14.3-aarch64 ?
FreeBSD-14.3-amd64 14.02% <0.00%> (-0.02%) ⬇️
Homebrew-ubuntu-22.04 14.71% <0.00%> (+0.10%) ⬆️
Linux-AppImage 12.82% <0.00%> (+0.10%) ⬆️
Windows-AMD64 14.97% <ø> (ø)
macOS-arm64 18.98% <11.76%> (-0.11%) ⬇️
macOS-x86_64 18.46% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/system_tray.cpp 4.07% <8.69%> (-4.55%) ⬇️

... and 40 files with indirect coverage changes

@ReenigneArcher ReenigneArcher force-pushed the fix/linux/migrate-to-qt-tray branch 4 times, most recently from 8640c4a to 4ee4ef1 Compare March 25, 2026 14:07
@ReenigneArcher ReenigneArcher marked this pull request as ready for review March 25, 2026 15:28
@ReenigneArcher ReenigneArcher marked this pull request as draft March 25, 2026 17:21
@ReenigneArcher ReenigneArcher force-pushed the fix/linux/migrate-to-qt-tray branch 8 times, most recently from b408d65 to 0c3386b Compare March 26, 2026 00:29
Add qt_log_to_boost() (Linux/FreeBSD) to forward Qt log messages into Sunshine's BOOST_LOG (maps Qt levels to debug/info/warning/error and guards against null messages). Register the callback via tray_set_log_callback during system tray initialization. Also update the third-party/tray submodule to the new commit.
@ReenigneArcher ReenigneArcher force-pushed the fix/linux/migrate-to-qt-tray branch 4 times, most recently from a52283f to 7295b20 Compare March 26, 2026 16:45
@sonarqubecloud
Copy link

Replace Qt5 dependencies with Qt6 across CI, docs, packaging and build scripts. Changes include FreeBSD workflow and docs switching to devel/qt6-base, Arch PKGBUILD and Linux build scripts using qt6 package names, Fedora/Copr spec updated to qt6 build/reqs and added conditional Qt5 fallback for OpenSUSE Leap. Homebrew formula now depends on qt@6 and qtbase, Ubuntu build flow enables the 'universe' repo for qt6 packages, and the third-party/tray submodule commit was bumped.
@ReenigneArcher ReenigneArcher force-pushed the fix/linux/migrate-to-qt-tray branch from 7295b20 to 68f0da9 Compare March 26, 2026 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant