Skip to content

chore: remove Module:HiddenSort#7702

Merged
Rathoz merged 1 commit into
mainfrom
hiddensort-to-widget3
Jul 3, 2026
Merged

chore: remove Module:HiddenSort#7702
Rathoz merged 1 commit into
mainfrom
hiddensort-to-widget3

Conversation

@ElectricalBoy

@ElectricalBoy ElectricalBoy commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator

Summary

Depends on #7704

How did you test this change?

trivial

@ElectricalBoy ElectricalBoy requested review from a team as code owners June 29, 2026 04:17

@hjpalpha hjpalpha left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we drop this entire module instead?
switch to using proper data sort stuff instead?
looks like only usages are in
https://liquipedia.net/fighters/Module:AchievementTable/Unified
https://liquipedia.net/commons/Module:MatchesScheduleDisplay

@ElectricalBoy

Copy link
Copy Markdown
Collaborator Author

@ElectricalBoy ElectricalBoy changed the title refactor: hiddensort to widget3 chore: remove Module:HiddenSort Jun 30, 2026
@ElectricalBoy ElectricalBoy marked this pull request as draft June 30, 2026 01:38
@Rathoz

Rathoz commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

Merge conflict

@ElectricalBoy ElectricalBoy force-pushed the hiddensort-to-widget3 branch from 51cb2ee to 9c3eb2a Compare July 3, 2026 00:13
@ElectricalBoy ElectricalBoy marked this pull request as ready for review July 3, 2026 00:13
@ElectricalBoy ElectricalBoy force-pushed the hiddensort-to-widget3 branch from 9c3eb2a to 500305a Compare July 3, 2026 00:15
@Rathoz Rathoz merged commit 97530f7 into main Jul 3, 2026
7 checks passed
@Rathoz Rathoz deleted the hiddensort-to-widget3 branch July 3, 2026 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants