fix: bless on Rosetta capable environments(arm64)#223
Open
SReject wants to merge 3 commits intoLinusU:masterfrom
Open
fix: bless on Rosetta capable environments(arm64)#223SReject wants to merge 3 commits intoLinusU:masterfrom
SReject wants to merge 3 commits intoLinusU:masterfrom
Conversation
|
Giving this a nudge. By default, Github Actions Runner runs in Rosetta mode on Apple Silicon devices. This means that currently, node-appdmg won't work in a Ventura CI build environment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
- bless doesn't support
--openfolderfor Apple Silicon based architectures.- With Rosetta transcoding the current check of
os.arch()returnsx86; this is why #205 did not solve the issue.- Other node-native potential checks also fail to identify Apple Silicon environments
Fix:
- Check
sysctl.proc_translatedand if it has a value assume the machine is Rosetta-capable and thus Apple SiliconImplementation:
- use
sysctlcommand to retrieve the value ofsysctl.proc_translated. If a value is returned it can be assumed the machine is Rosetta-capable.- Do not use
--openfolderwhen Rosetta-capability has been assumed.Tests:
- MacBook Air, 2020 (M1)
- MacBook Pro, 2021 (M1 Pro)
Addresses:
#216, #218, #219, #239