Conversation
WoWaster
marked this pull request as ready for review
June 30, 2026 14:38
gsvgit
reviewed
Jul 1, 2026
gsvgit
left a comment
gsvgit
left a comment
Member
There was a problem hiding this comment.
- What about readme with instructions. E.g. how to add more benchmarks.
- What about AGENTS.md ?
| logging.info("Converting matrices for inpla") | ||
| convert_matrices_to_inpla(matrices, matrices_path, inpla_bench_path) | ||
|
|
||
| # parser doesn't work |
Member
There was a problem hiding this comment.
Hmm... What is it for? What does it mean?
|
|
||
|
|
||
| def build_GraphBLAS(dependencies_path: Path): | ||
| subprocess.run(["make"], cwd=dependencies_path / "GraphBLAS", check=True) |
Member
There was a problem hiding this comment.
Move strings that used more than once to constant literals.
|
|
||
| matrices = get_enabled_matrices_for_tool(matrices_spec_path, Tool.LAGRAPH) | ||
|
|
||
| # parser doesn't work |
Member
There was a problem hiding this comment.
Again? Reading of the discussion does not help me to realize what happens.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.