Skip to content

chore: update pre-commit#77

Merged
jourdain merged 1 commit into
Kitware:masterfrom
Jo-Byr:update-pre-commit
May 11, 2026
Merged

chore: update pre-commit#77
jourdain merged 1 commit into
Kitware:masterfrom
Jo-Byr:update-pre-commit

Conversation

@Jo-Byr
Copy link
Copy Markdown
Contributor

@Jo-Byr Jo-Byr commented Apr 21, 2026

Update pre-commit configuration to align with latest trame standards

Comment thread src/trame_server/client.py
@Jo-Byr Jo-Byr force-pushed the update-pre-commit branch from bdf68c4 to 27114c7 Compare April 21, 2026 12:45
@Jo-Byr
Copy link
Copy Markdown
Contributor Author

Jo-Byr commented Apr 21, 2026

@jourdain Is there a reason for the Python version used to be 3.9 ? We need at least 3.10 for the new pre-commit versions to be installable, but we could even pass to 3.12

@jourdain
Copy link
Copy Markdown
Collaborator

The CI can use 3.12

@Jo-Byr Jo-Byr force-pushed the update-pre-commit branch 2 times, most recently from e662402 to 6e1edae Compare April 24, 2026 09:34
@Jo-Byr
Copy link
Copy Markdown
Contributor Author

Jo-Byr commented Apr 28, 2026

@jourdain I think this PR is fine to merge, I don't have the rights to dot it.

@jourdain
Copy link
Copy Markdown
Collaborator

jourdain commented May 2, 2026

Need rebase and resolve conflict

@jourdain
Copy link
Copy Markdown
Collaborator

jourdain commented May 2, 2026

All broken now...

@jourdain
Copy link
Copy Markdown
Collaborator

jourdain commented May 5, 2026

I fixed the repo. You should be able to rebase and fix conflict

Update pre-commit configuration to align with latest trame standards
@Jo-Byr Jo-Byr force-pushed the update-pre-commit branch from 6e1edae to 28f7c52 Compare May 11, 2026 06:52
@jourdain jourdain merged commit d175dfc into Kitware:master May 11, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants