Allow devDependency imports in TypeScript spec files - #1844
Merged
Conversation
This was referenced Aug 14, 2026
PaulHax
marked this pull request as ready for review
August 14, 2026 03:45
BryonLewis
self-requested a review
August 14, 2026 11:58
BryonLewis
approved these changes
Aug 14, 2026
PaulHax
force-pushed
the
eslint-unused-directives
branch
from
August 18, 2026 18:29
637984a to
f2eb233
Compare
BryonLewis
approved these changes
Aug 18, 2026
Enable --report-unused-disable-directives in the client lint script so unnecessary suppressions fail the gate, and drop the directives that no longer suppress anything.
Airbnb's import/no-extraneous-dependencies allowlist only covers .js and .jsx test files, so every TypeScript spec needed a hand-written disable comment. Scope the rule to permit devDependencies in *.spec.ts and drop the now-redundant suppressions.
PaulHax
force-pushed
the
eslint-unused-directives
branch
from
August 18, 2026 19:47
f2eb233 to
2563e23
Compare
romleiaj
added a commit
that referenced
this pull request
Aug 19, 2026
Client (eslint with main's new --report-unused-disable-directives, and vue-tsc, both now clean): - Drop import/no-extraneous-dependencies directives in spec files that main's #1844 made redundant, and no-await-in-loop ones that no longer fire. - function-paren-newline: collapse or one-arg-per-line the offending calls. - autoRegisterSelection: remove the dead empty-bin guard (bins <= usable guarantees every bin spans a frame) instead of using `continue`. - AutoRegisterDialog: unnest the pairCount ternary. - Justify the two reactive-touch `void` expressions with a scoped disable. - ViewerLoader: remove loadMultiCamMetadata, orphaned when the in-process auto-register service path was dropped; guard the null multiCamMedia branch in populateMultiCamImagePathGetters. - useMediaController: per-camera controllers now carry translateCameraFrame and cameraFrameToSlot, which the MediaController interface requires. - common.spec: seed and type the registration fixtures at format v2. Server (flake8/black/isort/mypy, now at parity with main): - black/isort formatting in registration_output.py and run_pipeline.py, wrap an over-long message in multicam_pipeline.py, D209 docstring in models.py. - _invert3 accepts Optional input so the leftToRight/rightToLeft fallback typechecks. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012JeU2DKMZAN2d4TSymbJyz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow devDependency imports in TypeScript spec files
The client lint command did not report unused ESLint directives. As a result, obsolete directives
could remain after the related lint errors were fixed.
The Airbnb
import/no-extraneous-dependenciesrule also permits test dependencies only inJavaScript test files. TypeScript spec files needed a manual directive when they imported
vitestor
@vue/test-utils.Changes
**/*.spec.tsfiles.This PR does not change application or test behavior. It changes the lint gate and removes obsolete
lint comments.
Hierarchy prerequisite
The hierarchy PRs add TypeScript spec files that import devDependencies, so this change lets them
pass the stricter lint gate without manual suppressions.
Stack
This is PR 1 of 9. Next: preserve Desktop import warnings.
This PR contains 2 commits on
origin/main:455c1524 Remove stale eslint-disable directives637984a3 Allow devDependency imports in spec filesOverall: 64 files, +18/-89.