Add time filter persistence, text inputs, and overlay settings panel#1592
Open
mattdawkins wants to merge 6 commits intomainfrom
Open
Add time filter persistence, text inputs, and overlay settings panel#1592mattdawkins wants to merge 6 commits intomainfrom
mattdawkins wants to merge 6 commits intomainfrom
Conversation
Save and load timeFilters in dataset metadata following the established confidenceFilters pattern. Filters are saved on every change (toggle, slider, timeline drag) and restored when the dataset is reopened. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Replace the hover-based v-menu with a click-toggled overlay panel that appears above the controls bar on the right third of the screen. Add frame number text fields and HH:MM:SS time inputs (for video datasets) alongside the existing sliders. Clicking the filter button enables the filter and opens settings; clicking again disables it; clicking outside closes the panel without disabling. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Pass start_frame, end_frame, and frame_range_is_native to the KWIVER downsampler when the user has selected a frame range, so VIAME skips frames outside the range rather than post-filtering. The is_native flag is set based on whether DIVE is downsampling (fps < originalFps). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ne type For transcode/filter pipelines with a frame range, renumber output frames relative to the new range (frame 0 = start frame). For all other pipelines, keep frames relative to the original video. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
mattdawkins
force-pushed
the
filter-range-in-pipes-and-adj-opt
branch
from
05f3341 to
f1e0542
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
confidenceFilterspattern) so filter state is restored when reopening a datasetstart_frame,end_frame, andframe_range_is_nativeto the KWIVER downsampler for video pipelines when a frame range is selected, so VIAME skips frames outside the range instead of post-filtering. Theframe_range_is_nativeflag is set dynamically based on whether DIVE is downsampling (fps < originalFps).Test plan
nulland is remembered-s downsampler:start_frame=N -s downsampler:end_frame=M -s downsampler:frame_range_is_native=...🤖 Generated with Claude Code