fix(mobile): restore last picked model and effort on new session - #6094
Open
iscekic wants to merge 1 commit into
Open
fix(mobile): restore last picked model and effort on new session#6094iscekic wants to merge 1 commit into
iscekic wants to merge 1 commit into
Conversation
Surface: the mobile app (apps/mobile). On the new session page, the last selected model/effort combo is not persisted, so the user is forced to pick for every new session. Persist the last picked model/effort combo and restore it on the new session page, with a reasonable fallback in case the persisted choice is not available.
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (2 files)
Reviewed the reordered resolution in Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0 Review guidance: REVIEW.md from base branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog for users
Changelog for maintainers
pickAutoSelectedModelnow resolves in this order: serverlastSelected, local stored preference, devkilo-auto/efficient, org default, first catalog entry.resolveModelForContextand falls through to the next source.pickVariant.handleModelSelect; this change fixes the restore priority, not the save path.E2E proof
Recording of the verified flow (waits trimmed)
scripted-shard1.mp4
E2E proof — log excerpts
/home/igor_kilocode_ai/.local/share/kwf/sections/persist-last-model-effort-choice-30cb/e2e-mobile-app/scripted-p1.log/home/igor_kilocode_ai/.local/share/kwf/sections/persist-last-model-effort-choice-30cb/e2e-mobile-app/p2-verify.log/home/igor_kilocode_ai/.local/share/kwf/sections/persist-last-model-effort-choice-30cb/e2e-mobile-app/p2-server-cleared.log/home/igor_kilocode_ai/.local/share/kwf/sections/persist-last-model-effort-choice-30cb/e2e-mobile-app/p2-forcequit.logOwner request