feat(billing): add on-demand usage reconciliation check - #4870
Conversation
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryThe incremental change since Resolved since previous review
Files Reviewed (1 file, incremental since 8d86c31)
Previous Review Summaries (5 snapshots, latest commit 8d86c31)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 8d86c31)Status: 1 Issue Found | Recommendation: Address before merge Executive SummaryBoth previously reported issues are fixed in Overview
Issue Details (click to expand)SUGGESTION
Resolved since previous review
Files Reviewed (3 files, incremental since e42d58a)
Fix these issues in Kilo Cloud Previous review (commit e42d58a)Status: 2 Issues Found | Recommendation: Address before merge Executive SummaryCollapsing the former Overview
Issue Details (click to expand)WARNING
SUGGESTION
Files Reviewed (3 files, incremental since b2bc5fd)
Fix these issues in Kilo Cloud Previous review (commit b2bc5fd)Status: No Issues Found | Recommendation: Merge Executive SummaryIncremental update hardens reconciliation state handling (deduplicated Files Reviewed (5 files)
Previous review (commit 97131ec)Status: No Issues Found | Recommendation: Merge Executive SummaryIncremental update only removes the Playwright e2e spec ( Files Reviewed (7 files)
Previous review (commit 067a8d2)Status: No Issues Found | Recommendation: Merge Files Reviewed (8 files)
Reviewed by claude-opus-5 · Input: 30 · Output: 3.5K · Cached: 565.2K Review guidance: REVIEW.md from base branch |
Summary
[start, end)window.containersUsageAdaptiveGroupsonly for physical Cloudflare instance IDs already recorded by the meter, with account settings, retention, duration, page-size, request-count, timeout, and raw-response bounds enforced.CLOUDFLARE_ACCOUNT_IDandCLOUDFLARE_ANALYTICS_API_TOKENoptional at application startup; missing configuration fails only when an admin invokes reconciliation.Verification
pnpm --filter web test -- --runInBand src/lib/cloudflare/container-usage-analytics.test.ts src/routers/admin/cloud-billing-skus-router.test.tspnpm --filter web typecheckpnpm --filter web lintVisual Changes
Reviewer Notes
[start, end)scoping, physical instance deduplication, andinstanceId_inprovider filter closely; these prevent unrelated usage from entering the report.applicationIdis reported without a hardcoded application-name assumption; multiple applications for one physical instance are surfaced as ambiguous.