Fix rem of a Rational into a Normed type

[PatrickHaecker]

(1//3) % N0f8 threw a MethodError, because _unsafe_trunc fell back to unsafe_trunc, which had no Rational method.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.84%. Comparing base (b863f66) to head (c5bfe2d).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #349   +/-   ##
=======================================
  Coverage   96.83%   96.84%           
=======================================
  Files           7        7           
  Lines         791      793    +2     
=======================================
+ Hits          766      768    +2     
  Misses         25       25           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[kimikage]

Good catch.

In actual cases, the denominator should always be 1, but I don't think that is a major issue.

Although it is not the focus of this PR, I think it would be good to have tests for Fixed as well, for the sake of the future.

[PatrickHaecker]

In actual cases, the denominator should always be 1, but I don't think that is a major issue.

Oh, indeed. _rem rounds first, so the Rational is always integral there. However, I just checked: The compiler already drops the division. So I kept the version that is correct for any Rational – more generic with same speed (but by luck, so thanks for pointing it out).

Although it is not the focus of this PR, I think it would be good to have tests for Fixed as well, for the sake of the future.

• I have added the same kind of tests for Q0f7.

[kimikage]

Thank you for your contribution.