Skip to content

Special handling for length=1 #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
tkf wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Special handling for length=1 #114

tkf wants to merge 1 commit into from

Conversation

@tkf
Copy link
Member

@tkf tkf commented Jan 23, 2020

No description provided.

@tkf-bot
Copy link
Contributor

tkf-bot commented Jan 23, 2020

Benchmark result

Judge result

Benchmark Report for /home/runner/work/BangBang.jl/BangBang.jl

Job Properties

  • Time of benchmarks:
    • Target: 23 Jan 2020 - 02:43
    • Baseline: 23 Jan 2020 - 02:44
  • Package commits:
    • Target: 6eed32
    • Baseline: 0745bf
  • Julia commits:
    • Target: 2d5741
    • Baseline: 2d5741
  • Julia command flags:
    • Target: None
    • Baseline: None
  • Environment variables:
    • Target: None
    • Baseline: None

Results

A ratio greater than 1.0 denotes a possible regression (marked with ❌), while a ratio less
than 1.0 denotes a possible improvement (marked with ✅). Only significant results - results
that indicate possible regressions or improvements - are shown below (thus, an empty table means that all
benchmark results remained invariant between builds).

ID time ratio memory ratio
["append", "append!!(::Vector, ::SingletonVector)"] 1.16 (5%) ❌ 1.00 (1%)
["dataframes", "Categorical"] 0.83 (5%) ✅ 1.00 (1%)

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["append"]
  • ["dataframes"]

Julia versioninfo

Target

Julia Version 1.3.1
Commit 2d5741174c (2019-12-30 21:36 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 18.04.3 LTS
  uname: Linux 5.0.0-1028-azure #30~18.04.1-Ubuntu SMP Fri Dec 6 11:47:59 UTC 2019 x86_64 x86_64
  CPU: Intel(R) Xeon(R) CPU E5-2673 v3 @ 2.40GHz: 
              speed         user         nice          sys         idle          irq
       #1  2394 MHz      10804 s          0 s        856 s      12088 s          0 s
       #2  2394 MHz       7716 s          0 s       1168 s      15484 s          0 s
       
  Memory: 6.782741546630859 GB (3726.765625 MB free)
  Uptime: 254.0 sec
  Load Avg:  1.04736328125  0.82666015625  0.38037109375
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-6.0.1 (ORCJIT, haswell)

Baseline

Julia Version 1.3.1
Commit 2d5741174c (2019-12-30 21:36 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 18.04.3 LTS
  uname: Linux 5.0.0-1028-azure #30~18.04.1-Ubuntu SMP Fri Dec 6 11:47:59 UTC 2019 x86_64 x86_64
  CPU: Intel(R) Xeon(R) CPU E5-2673 v3 @ 2.40GHz: 
              speed         user         nice          sys         idle          irq
       #1  2394 MHz      16830 s          0 s        943 s      13012 s          0 s
       #2  2394 MHz       8724 s          0 s       1199 s      21505 s          0 s
       
  Memory: 6.782741546630859 GB (3673.6484375 MB free)
  Uptime: 325.0 sec
  Load Avg:  1.0126953125  0.865234375  0.42822265625
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-6.0.1 (ORCJIT, haswell)

Target result

Benchmark Report for /home/runner/work/BangBang.jl/BangBang.jl

Job Properties

  • Time of benchmark: 23 Jan 2020 - 2:43
  • Package commit: 6eed32
  • Julia commit: 2d5741
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["append", "append!!(::SVector, ::SingletonVector)"] 13.844 ms (5%) 16.78 MiB (1%) 600000
["append", "append!!(::Vector, ::SingletonVector)"] 654.901 μs (5%)
["append", "append!!(Empty(SVector), ::SingletonVector)"] 4.100 ns (5%)
["dataframes", "Categorical"] 746.352 ms (5%) 95.949 ms 992.89 MiB (1%) 6318092
["dataframes", "Int-Int"] 1.620 ms (5%) 160.23 KiB (1%) 10251
["dataframes", "Missing-Int"] 2.111 ms (5%) 160.23 KiB (1%) 10251
["dataframes", "Missing-String"] 1.996 ms (5%) 160.27 KiB (1%) 10252
["dataframes", "String-String"] 2.027 ms (5%) 160.27 KiB (1%) 10252

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["append"]
  • ["dataframes"]

Julia versioninfo

Julia Version 1.3.1
Commit 2d5741174c (2019-12-30 21:36 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 18.04.3 LTS
  uname: Linux 5.0.0-1028-azure #30~18.04.1-Ubuntu SMP Fri Dec 6 11:47:59 UTC 2019 x86_64 x86_64
  CPU: Intel(R) Xeon(R) CPU E5-2673 v3 @ 2.40GHz: 
              speed         user         nice          sys         idle          irq
       #1  2394 MHz      10804 s          0 s        856 s      12088 s          0 s
       #2  2394 MHz       7716 s          0 s       1168 s      15484 s          0 s
       
  Memory: 6.782741546630859 GB (3726.765625 MB free)
  Uptime: 254.0 sec
  Load Avg:  1.04736328125  0.82666015625  0.38037109375
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-6.0.1 (ORCJIT, haswell)

Baseline result

Benchmark Report for /home/runner/work/BangBang.jl/BangBang.jl

Job Properties

  • Time of benchmark: 23 Jan 2020 - 2:44
  • Package commit: 0745bf
  • Julia commit: 2d5741
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["append", "append!!(::SVector, ::SingletonVector)"] 14.218 ms (5%) 16.78 MiB (1%) 600000
["append", "append!!(::Vector, ::SingletonVector)"] 564.101 μs (5%)
["append", "append!!(Empty(SVector), ::SingletonVector)"] 4.100 ns (5%)
["dataframes", "Categorical"] 896.210 ms (5%) 92.963 ms 992.89 MiB (1%) 6318092
["dataframes", "Int-Int"] 1.651 ms (5%) 160.23 KiB (1%) 10251
["dataframes", "Missing-Int"] 2.084 ms (5%) 160.23 KiB (1%) 10251
["dataframes", "Missing-String"] 1.990 ms (5%) 160.27 KiB (1%) 10252
["dataframes", "String-String"] 2.015 ms (5%) 160.27 KiB (1%) 10252

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["append"]
  • ["dataframes"]

Julia versioninfo

Julia Version 1.3.1
Commit 2d5741174c (2019-12-30 21:36 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 18.04.3 LTS
  uname: Linux 5.0.0-1028-azure #30~18.04.1-Ubuntu SMP Fri Dec 6 11:47:59 UTC 2019 x86_64 x86_64
  CPU: Intel(R) Xeon(R) CPU E5-2673 v3 @ 2.40GHz: 
              speed         user         nice          sys         idle          irq
       #1  2394 MHz      16830 s          0 s        943 s      13012 s          0 s
       #2  2394 MHz       8724 s          0 s       1199 s      21505 s          0 s
       
  Memory: 6.782741546630859 GB (3673.6484375 MB free)
  Uptime: 325.0 sec
  Load Avg:  1.0126953125  0.865234375  0.42822265625
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-6.0.1 (ORCJIT, haswell)

Runtime information

Runtime Info
BLAS #threads 2
BLAS.vendor() openblas64
Sys.CPU_THREADS 2

lscpu output:

Architecture:        x86_64
CPU op-mode(s):      32-bit, 64-bit
Byte Order:          Little Endian
CPU(s):              2
On-line CPU(s) list: 0,1
Thread(s) per core:  1
Core(s) per socket:  2
Socket(s):           1
NUMA node(s):        1
Vendor ID:           GenuineIntel
CPU family:          6
Model:               63
Model name:          Intel(R) Xeon(R) CPU E5-2673 v3 @ 2.40GHz
Stepping:            2
CPU MHz:             2394.453
BogoMIPS:            4788.90
Hypervisor vendor:   Microsoft
Virtualization type: full
L1d cache:           32K
L1i cache:           32K
L2 cache:            256K
L3 cache:            30720K
NUMA node0 CPU(s):   0,1
Flags:               fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm invpcid_single pti fsgsbase bmi1 avx2 smep bmi2 erms invpcid xsaveopt md_clear
Cpu Property Value
Brand Intel(R) Xeon(R) CPU E5-2673 v3 @ 2.40GHz
Vendor :Intel
Architecture :Haswell
Model Family: 0x06, Model: 0x3f, Stepping: 0x02, Type: 0x00
Cores 2 physical cores, 2 logical cores (on executing CPU)
No Hyperthreading detected
Clock Frequencies Not supported by CPU
Data Cache Level 1:3 : (32, 256, 30720) kbytes
64 byte cache line size
Address Size 48 bits virtual, 44 bits physical
SIMD 256 bit = 32 byte max. SIMD vector size
Time Stamp Counter TSC is accessible via rdtsc
TSC increased at every clock cycle (non-invariant TSC)
Perf. Monitoring Performance Monitoring Counters (PMC) are not supported
Hypervisor Yes, Microsoft

@codecov-io
Copy link

codecov-io commented Jan 23, 2020 •
edited
Loading

Codecov Report

Merging #114 into master will decrease coverage by 0.49%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #114     +/-   ##
=========================================
- Coverage   86.81%   86.32%   -0.5%     
=========================================
  Files          20       20             
  Lines         349      351      +2     
=========================================
  Hits          303      303             
- Misses         46       48      +2
Impacted Files Coverage Δ
src/NoBang/base.jl 93.5% <ø> (-2.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0745bfa...5ddf4fa. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tkf @tkf-bot @codecov-io