Conversation
Member
|
This looks like a fantastic improvement in accuracy -- I'm definitely in favour of doing this. Would definitely be good to prevent reverting by tying this down with a couple of unit tests. The above snippets would probably suffice. |
Member
Author
|
I think the improvements are only really big when using higher order and a high degree of |
Member
Oh okay. Would be good to see some numbers on this then, both benchmarking and accuracy. |
Member
Author
|
tests have been added |
willtebbutt
approved these changes
Apr 5, 2020
Member
willtebbutt
left a comment
There was a problem hiding this comment.
LGTM modulo the typo! Thanks @oxinabox
oxinabox
commented
Apr 6, 2020
Co-Authored-By: willtebbutt <wt0881@my.bristol.ac.uk>
e7e4750 to
7eed57f
Compare
This was referenced Apr 15, 2020
Merged
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #64
Turns out this can make a difference.
This not only gets result on julia 1.4 up to the standard of julia 1.2,
but actually does much more than that, significantly improving out accuracy
With this PR. in julia 1.2 or 1.4 (identical):
Without this PR. 1.4
Without this PR on 1.2
I feel like this is going to increase our cost a fair bit.
So it would be really good to get #61 done, to avoid recomputing coeffs.