fix: Avoid repeated extinction law construction in redden!/deredden!

[Akshat1000Sharma]

This PR improves the implementation of redden! and deredden! in src/transforms/redden.jl.

Previously the implementation broadcasted directly over the extinction law type:

@. f = DustExtinction.redden(law, s, f; Rv, Av)

When law is provided as a Type (e.g. the default DustExtinction.CCM89), the broadcast dispatch calls the type-based method of DustExtinction.redden for every wavelength element. This leads to constructing the extinction law instance (e.g. CCM89(Rv=3.1)) repeatedly.

This PR instead constructs the extinction law instance once and then applies the broadcast using that instance:

law_instance = law isa DustExtinction.ExtinctionLaw ? law : law(Rv=Rv)
@. f = DustExtinction.redden(law_instance, s, f; Av)

The same change is applied to deredden!.

Benefits

• Avoids repeated construction of extinction law objects
• Keeps the public API unchanged
• Continues delegating reddening calculations to DustExtinction.jl

Future work

There is ongoing upstream work adding in-place versions of these functions in DustExtinction.jl:

JuliaAstro/DustExtinction.jl#84

Once those functions (redden! / deredden!) are available in a released version, Spectra.jl could simplify this further by delegating directly to those implementations. (Once that happens, it will also fix #45 )

Testing

All existing tests (224/224) pass successfully.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.38%. Comparing base (9905292) to head (c0a91a6).

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #48      +/-   ##
==========================================
- Coverage   90.74%   90.38%   -0.36%     
==========================================
  Files           8        8              
  Lines         162      156       -6     
==========================================
- Hits          147      141       -6     
  Misses         15       15              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[icweaver]

Thanks for the contribution! I've upstreamed the instance logic to DustExtinction.jl to make the changes here a bit more general. Should be good to go after the next version there is registered JuliaRegistries/General#159484