Allow block multiplication of non-square blocks#127
Open
cvsvensson wants to merge 3 commits intoJuliaArrays:masterfrom
Open
Allow block multiplication of non-square blocks#127cvsvensson wants to merge 3 commits intoJuliaArrays:masterfrom
cvsvensson wants to merge 3 commits intoJuliaArrays:masterfrom
Conversation
Allow multiplication of non-square blocks
Codecov Report
@@ Coverage Diff @@
## master #127 +/- ##
==========================================
+ Coverage 98.89% 98.93% +0.04%
==========================================
Files 5 5
Lines 361 375 +14
==========================================
+ Hits 357 371 +14
Misses 4 4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
What is the status of this PR? Can we get this done and merged? |
Member
|
I think development will be easier if support for old versions of Julia is dropped. I'll create a PR for that, following which we may rebase this PR and check. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, BlockDiagonals keeps the block structure in matrix multiplication only if the blocks that are multiplied together have the same size. This is overly restrictive and rules out multiplication with non-square blocks.
This PR modifies the check done when multiplying BlockDiagonals to permit multiplication with non-square blocks while retaining the block diagonal structure.
In addition, the overhead of checking if blocks can be multiplied or added has been reduced.