Open
Conversation
Collaborator
Author
|
I finally tested this on real data. The overhead of doing on-the-fly correction to just loading and transforming a single dataset is about 20-25%, which seems reasonable to me. @mkitti please have a look and let me know if you run into any problems. There are a couple of xml files that show how to specify flatfield images and coding agents should be pretty good at extending those to cloud-hosted data. This was only tested for two setups (one local, one s3-hosted), so I still expect some rough edges. |
|
Also pinging @indecisiveuser for testing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to update the lazy flatfield correction code in
net.preibisch.mvrecon.fiji.spimdata.imgloaders.flatfieldin several ways:ViewerImgLoaderinterfaceThis is still a draft as more features will likely still be added.