Use explicit --manifest-path for pixi jobs instead of unsetting PIXI_PROJECT_MANIFEST#406
Open
mkitti wants to merge 1 commit into
Open
Use explicit --manifest-path for pixi jobs instead of unsetting PIXI_PROJECT_MANIFEST#406mkitti wants to merge 1 commit into
mkitti wants to merge 1 commit into
Conversation
…PROJECT_MANIFEST pixi's --manifest-path flag always overrides the PIXI_PROJECT_MANIFEST env var, so pointing pixi run at the manifest directory explicitly is more robust than unsetting the env var and relying on cwd-based discovery. Introduces FG_MANIFEST_DIR, exported alongside FG_WORK_DIR for all job types. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2 tasks
Member
|
Nice, I like it! |
Member
|
But I think we still need the I'm going to fix the ENV leakage on a separate PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--manifest-pathflag always overrides thePIXI_PROJECT_MANIFESTenv var (verified against pixi 0.70.2), so this switches the generated pixi command topixi run --manifest-path "$FG_MANIFEST_DIR" <task>instead of unsettingPIXI_PROJECT_MANIFESTand relying on cwd-based manifest discovery.FG_MANIFEST_DIR, exported alongsideFG_WORK_DIRin every generated job script (all app types, not just pixi), pointing at the directory containing the app's manifest.tests/test_apps.pyto assert on the new preamble.Supersedes #405 (moved from a fork branch to a branch within this repo).
Test plan
pixi run -e test test-backend— all 723 tests pass🤖 Generated with Claude Code