Update test asmdefs & add package testables#8
Merged
IvanMurzak merged 1 commit intomainfrom Mar 11, 2026
Merged
Conversation
Refactor test assembly definitions across package and multiple Unity test projects: remove direct UnityEngine.TestRunner/UnityEditor.TestRunner references and nunit.framework.dll precompiled references, add optionalUnityReferences: ["TestAssemblies"], set defineConstraints to ["UNITY_INCLUDE_TESTS"] and clear precompiledReferences. Add "testables": ["com.ivanmurzak.unity.mcp.particlesystem"] to each test manifest so the package is discoverable by Unity test runners. Also slim down Unity-Package.slnx to include only the ParticleSystem projects. These changes migrate tests to use Unity's TestAssemblies workflow and make the package testable across the provided Unity versions.
There was a problem hiding this comment.
Pull request overview
Updates Unity test project configuration so the com.ivanmurzak.unity.mcp.particlesystem package tests can be discovered/compiled across multiple Unity versions, while simplifying test assembly references.
Changes:
- Mark
com.ivanmurzak.unity.mcp.particlesystemas a testable package in the Unity test projects’Packages/manifest.json. - Update Unity test
.asmdeffiles to useoptionalUnityReferences: ["TestAssemblies"]instead of explicit TestRunner/NUnit references. - Trim
Unity-Package.slnxproject entries to focus on the ParticleSystem assemblies.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Unity-Tests/6000.3.1f1/Packages/manifest.json | Adds testables entry for the ParticleSystem package. |
| Unity-Tests/6000.3.1f1/Assets/RuntimeTests/RuntimeTests.asmdef | Switches tests to optionalUnityReferences: ["TestAssemblies"] and removes explicit runner/NUnit references. |
| Unity-Tests/6000.3.1f1/Assets/EditorTests/EditorTests.asmdef | Same as above for editor tests. |
| Unity-Tests/2023.2.22f1/Packages/manifest.json | Adds testables entry for the ParticleSystem package. |
| Unity-Tests/2023.2.22f1/Assets/RuntimeTests/RuntimeTests.asmdef | Switches tests to optionalUnityReferences: ["TestAssemblies"] and removes explicit runner/NUnit references. |
| Unity-Tests/2023.2.22f1/Assets/EditorTests/EditorTests.asmdef | Same as above for editor tests. |
| Unity-Tests/2022.3.62f3/Packages/manifest.json | Adds testables entry for the ParticleSystem package. |
| Unity-Tests/2022.3.62f3/Assets/RuntimeTests/RuntimeTests.asmdef | Switches tests to optionalUnityReferences: ["TestAssemblies"] and removes explicit runner/NUnit references. |
| Unity-Tests/2022.3.62f3/Assets/EditorTests/EditorTests.asmdef | Same as above for editor tests. |
| Unity-Package/Unity-Package.slnx | Removes non-ParticleSystem project entries from the solution definition. |
| Unity-Package/Assets/root/Tests/Runtime/com.IvanMurzak.Unity.MCP.ParticleSystem.Tests.asmdef | Removes explicit TestRunner/NUnit references and uses optionalUnityReferences: ["TestAssemblies"]. |
| Unity-Package/Assets/root/Tests/Editor/com.IvanMurzak.Unity.MCP.ParticleSystem.Editor.Tests.asmdef | Same as above; also adds UNITY_INCLUDE_TESTS define constraint. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor test assembly definitions across package and multiple Unity test projects: remove direct UnityEngine.TestRunner/UnityEditor.TestRunner references and nunit.framework.dll precompiled references, add optionalUnityReferences: ["TestAssemblies"], set defineConstraints to ["UNITY_INCLUDE_TESTS"] and clear precompiledReferences. Add "testables": ["com.ivanmurzak.unity.mcp.particlesystem"] to each test manifest so the package is discoverable by Unity test runners. Also slim down Unity-Package.slnx to include only the ParticleSystem projects. These changes migrate tests to use Unity's TestAssemblies workflow and make the package testable across the provided Unity versions.