Skip to content

Comments

[SDK-366] Parse media#818

Open
lposen wants to merge 2 commits intoloren/embedded/SDK-366-new-parse-styles-for-componentsfrom
loren/embedded/SDK-367-parse-media-for-components
Open

[SDK-366] Parse media#818
lposen wants to merge 2 commits intoloren/embedded/SDK-366-new-parse-styles-for-componentsfrom
loren/embedded/SDK-367-parse-media-for-components

Conversation

@lposen
Copy link
Contributor

@lposen lposen commented Feb 24, 2026

🔹 JIRA Ticket(s) if any

✏️ Description

Parse media for the message

Test

  • Run example app
  • Go to embedded tab
  • Click "get messages for placement ids"
  • You should see the details of the media associated with those placemebt ids below the hr
Screen.Recording.2026-02-23.at.5.31.35.PM.mov

@github-actions
Copy link

github-actions bot commented Feb 24, 2026

Lines Statements Branches Functions
Coverage: 64%
64.38% (443/688) 47.17% (142/301) 61.25% (147/240)

@qltysh
Copy link

qltysh bot commented Feb 24, 2026

Qlty

Coverage Impact

⬆️ Merging this pull request will increase total coverage on loren/embedded/SDK-366-new-parse-styles-for-components by 0.47%.

Modified Files with Diff Coverage (3)

RatingFile% DiffUncovered Line #s
Coverage rating: A Coverage rating: A
src/embedded/hooks/useEmbeddedView/useEmbeddedView.ts100.0%
Coverage rating: A Coverage rating: A
src/embedded/components/IterableEmbeddedView.tsx100.0%
New file Coverage rating: A
src/embedded/hooks/useEmbeddedView/getMedia.ts100.0%
Total100.0%
🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@qltysh
Copy link

qltysh bot commented Feb 24, 2026

4 new issues

Tool Category Rule Count
qlty Structure Function with many parameters (count = 4): getMedia 2
qlty Structure Function with many returns (count = 5): IterableEmbeddedView 1
qlty Structure Function with high complexity (count = 11): IterableEmbeddedView 1

{media.url ? <Image source={{ uri: media.url }} width={100} height={100} /> : null}
<Cmp {...props} />
</View>
) : null;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 2 issues:

1. Function with many returns (count = 5): IterableEmbeddedView [qlty:return-statements]


2. Function with high complexity (count = 11): IterableEmbeddedView [qlty:function-complexity]

/** The type of view to render. */
viewType: IterableEmbeddedViewType,
/** The message to render. */
message: IterableEmbeddedMessage
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function with many parameters (count = 4): getMedia [qlty:function-parameters]

{
config,
message,
}: IterableEmbeddedComponentProps
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function with many parameters (count = 4): useEmbeddedView [qlty:function-parameters]

@lposen lposen marked this pull request as ready for review February 24, 2026 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant