[SDK-337] Auto hide status bar flag for in-app messages fullscreen#988
Open
franco-zalamena-iterable wants to merge 3 commits intomasterfrom
Open
[SDK-337] Auto hide status bar flag for in-app messages fullscreen#988franco-zalamena-iterable wants to merge 3 commits intomasterfrom
franco-zalamena-iterable wants to merge 3 commits intomasterfrom
Conversation
franco-zalamena-iterable
force-pushed
the
SDK-337-in-app-close-button-position
branch
from
79b5978 to
44f314a
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
iterableapi/src/main/java/com/iterable/iterableapi/IterableInAppFragmentHTMLNotification.java
Dismissed
Show dismissed
Hide dismissed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔹 Jira Ticket(s) if any
✏️ Description
We had a problem with fullscreen in-app messages, some clients were getting the close button behind the status bar and losing the ability to close the message.
The flag
FLAG_FULLSCREENwas just making the content appear under the status bar but blocking clicks and obstructing the view.The new behavior is to match what the app itself is using, so if the app is "edge-to-edge" the in-app will display accordingly.
If it is an app respecting system bars, the in-app will also do the same.
The core change is that before we were calculating the real size of the window and making the in-app that size, then applying
FLAG_FULLSCREENto make the content show behind the status bar, but since bothFLAG_FULLSCREENandSTATUS_BAR_TRANSLUCENTare deprecated they were not getting the correct behavior out of it and the content was just shown behind the status bar