Skip to content

[BUG] UpdateComprehensiveResult overwrites failure description instead of accumulating it #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
peterbarancek merged 2 commits into from
Jun 3, 2026
Merged

[BUG] UpdateComprehensiveResult overwrites failure description instead of accumulating it #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bbd0e56
Create draft PR for #54
github-actions[bot] Jun 3, 2026
ce5f4e8
Fix comprehensive result accumulation to prevent overwriting failure …
peterbarancek Jun 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/TcoInspectors/src/XAE/XAE/TcoInspectors/POUs/TcoInspectionGroup/TcoInspectionGroup.TcPOU
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -528,6 +528,10 @@ _refOverallResult REF= inoResult;
IF(_tierUpdateOverall.IsNewTier()) THEN
_originalOverallResult := inoResult;
END_IF
IF _coordinator.IsFreshState THEN
_originalOverallResult := inoResult;
END_IF



CASE _currentRunResult.Result OF
Expand All @@ -536,10 +540,10 @@ CASE _currentRunResult.Result OF
eOverallResult.Passed:
;
eOverallResult.Failed:

_refOverallResult:=_originalOverallResult;
_refOverallResult.Result := eOverallResult.Failed;
_refOverallResult.Failures := _currentRunResult.Failures;
_refOverallResult.ErrorCodes := _currentRunResult.ErrorCodes;
_refOverallResult.Failures := concat(concat(_refOverallResult.Failures,';'), _currentRunResult.Failures);
_refOverallResult.ErrorCodes := concat(concat(_refOverallResult.ErrorCodes,';'),_currentRunResult.ErrorCodes);
END_CASE


Expand Down
20 changes: 14 additions & 6 deletions src/TcoInspectors/src/XAE/XAE/TcoInspectors/POUs/TcoInspector/TcoInspector.TcPOU
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -637,6 +637,9 @@ _refOverallResult REF= inoResult;
IF (_tierUpdateOverall.IsNewTier()) THEN
_originalOverallResult := inoResult;
END_IF
IF _coordinator.IsFreshState THEN
_originalOverallResult := inoResult;
END_IF

IF (NOT __ISVALIDREF(_inspectorTask.InspectionData)) THEN
inoResult.Result := eOverallResult.NoAction;
Expand All @@ -651,11 +654,13 @@ CASE _inspectorTask.InspectionData.Result OF
eInspectorResult.Passed:
;
eInspectorResult.Failed:
inoResult.Result := eOverallResult.Failed;
UpdateDescriptions(inoResult);
_refOverallResult:=_originalOverallResult;
_refOverallResult.Result := eOverallResult.Failed;
UpdateDescriptions(_originalOverallResult,inoResult);
eInspectorResult.Inconclusive:
inoResult.Result := eOverallResult.Failed;
UpdateDescriptions(inoResult);
_refOverallResult:=_originalOverallResult;
_refOverallResult.Result := eOverallResult.Failed;
UpdateDescriptions(_originalOverallResult,inoResult);
eInspectorResult.Excluded:
;
eInspectorResult.Bypassed:
Expand All @@ -672,20 +677,23 @@ END_CASE]]></ST>
</docu>
~*)
METHOD PROTECTED UpdateDescriptions
VAR_INPUT
inOriginalResult:TcoComprehensiveResult;;
END_VAR
VAR_IN_OUT
inoResult : TcoComprehensiveResult;
END_VAR
]]></Declaration>
<Implementation>
<ST><![CDATA[IF(_inspectorTask.OnDoneFlag) THEN
inoResult.Failures := THIS^.Context.Environment.Messaging.StringBuilder.Clear()
.Append(inoResult.Failures)
.Append(inOriginalResult.Failures)
.Append(_inspectorTask.InspectionData.FailureDescription)
.Append(';')
.ToString();

inoResult.ErrorCodes := THIS^.Context.Environment.Messaging.StringBuilder.Clear()
.Append(inoResult.ErrorCodes)
.Append(inOriginalResult.ErrorCodes)
.Append(_inspectorTask.InspectionData.ErrorCode)
.Append(';')
.ToString();
Expand Down
Loading