Skip to content

Support dpctl in virtual environment on Windows out of the box #1922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oleksandr-pavlyk merged 4 commits into from
Dec 7, 2024
Merged

Support dpctl in virtual environment on Windows out of the box #1922

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9cdc8e4
Support dpctl in vritual environment out of the box
oleksandr-pavlyk Dec 4, 2024
d8bc19e
Update dpctl/_init_helper.py
oleksandr-pavlyk Dec 5, 2024
eab51fd
More robust check that VIRUAL_ENV is valid
oleksandr-pavlyk Dec 6, 2024
c6eea90
Avoid reliance of VIRTUAL_ENV environment variable
oleksandr-pavlyk Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions dpctl/_init_helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@
# with DPC++ libraries to the DLL search path gh-1745
if "VIRTUAL_ENV" in os.environ:
venv_dir = os.environ["VIRTUAL_ENV"]
expected_dir = os.path.join(venv_dir, "Library", "bin")
if os.path.exists(expected_dir):
os.add_dll_directory(expected_dir)
# Expect to find file per PEP-0405
expected_file = os.path.join(venv_dir, "pyvenv.cfg")
dll_dir = os.path.join(venv_dir, "Library", "bin")
if os.path.isdir(dll_dir) and os.path.isfile(expected_file):
os.add_dll_directory(dll_dir)
Comment thread
oleksandr-pavlyk marked this conversation as resolved.
Outdated