STYLE: Remove VTK 8 and VTK 5 branches from examples - #488
Merged
hjmjohnson merged 2 commits intoSep 16, 2026
Merged
hjmjohnson merged 2 commits into
hjmjohnson merged 2 commits into
Conversation
ITK's VtkGlue requires VTK 9.1, so the VTK_VERSION VERSION_LESS "8.90.0" branches can never be taken. Drop the VTK_USE_FILE includes and the _vtk_prefix component prefix, and call vtk_module_autoinit unconditionally. Suggested in review of InsightSoftwareConsortium#481.
With VTK 9.1 required, the VTK_MAJOR_VERSION <= 5 SetInput branches are dead. Keep the SetInputData path and drop the vtkVersion.h includes that only served those checks.
github-actions
Bot
added
area:Core
hjmjohnson
marked this pull request as ready for review
September 15, 2026 20:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the VTK 8 and VTK 5 branches from the examples. ITK's VtkGlue requires VTK 9.1, so none of them can run. Addresses dzenanz's review comment on #481.
Review comment
#481 (comment)
What changed
CMake (57 files):
include(${VTK_USE_FILE})branches._vtk_prefixcomponent prefix.vtk_module_autoinitwithout a version guard.C++ (13 files):
SetInputDatacode path.SetInputbranches.vtkVersion.hincludes, which only served those checks.The change is repo-wide rather than Bridge-only. The same dead branches
also exist in Core, Filtering, Registration, Segmentation, and Remote.
Local verification
Built against ITK
mainwith VtkGlue on and VTK 9.6, on macOS arm64. Thebuild had 0 failures.
Remote/WikiExamples(2 examples) is not built: the module is off.ConnectedComponentsInImageis commented out onmainwith a TODO.Tests matching the touched examples ran 59 of 60 passing. The one failure
is
ConvolveImageWithKernelTestPython, which failed onimport itk. Thatcomes from the local Python environment, and the test's directory is not
changed here.
pre-commit run --all-filespasses.🤖 Generated with Claude Code
https://claude.ai/code/session_01S5zzoU6yyUwdLEvjM2s6iS