Conversation
There was a problem hiding this comment.
Do you really need this file?
| import { IgrColumn, IgrFilteringExpressionsTree, IgrFilteringStrategy } from "igniteui-react-grids"; | ||
|
|
||
| const DATA_URL = 'https://services.odata.org/V4/Northwind/Northwind.svc/Products'; | ||
| const EMPTY_STRING = ''; |
| const filterExpr = this.buildFilterExpression(filteringArgs); | ||
| if (filterExpr) parts.push(filterExpr); | ||
|
|
||
| return `${baseQuery}&${parts.join('&')}`; |
There was a problem hiding this comment.
Same problem with URL ending in '&'
… used enums for types
MarielaTihova
left a comment
MarielaTihova
left a comment
There was a problem hiding this comment.
Please resolve comments
There was a problem hiding this comment.
This file is not needed
| }; | ||
|
|
||
| useEffect(() => { | ||
| fetchData(); // initial load |
There was a problem hiding this comment.
Shouldn't we make a new request when we scroll to see the remaining data in the grid instead of fetching everything at once?
There was a problem hiding this comment.
Shouldn't we keep the behaviour consistent here? For example look at this sample for Angular here https://www.infragistics.com/angular-demos/grid/grid-sample-4. A new request is being made on every scroll.
There was a problem hiding this comment.
I suppose it is the ngAfterViewInit in angular that makes that possible, but you will get empty grid if we remove the initial load. Do you have a suggestion?
There was a problem hiding this comment.
📌 Putting a pin on this to discuss more about the behaviour.
|
|
||
| // Initialize the filtering strategy for RemoteService | ||
| useEffect(() => { | ||
| RemoteService._filteringStrategy = new IgrFilteringStrategy(); |
There was a problem hiding this comment.
This produces an error. Sample doesn't run. Please check it
…nd request cancellation
| <!-- NOTE: do not change this file because it's auto re-generated from template: --> | ||
| <!-- https://github.com/IgniteUI/igniteui-react-examples/tree/vnext/templates/sample/ReadMe.md --> | ||
|
|
||
| This folder contains implementation of React application with example of Filtering Options feature using [Grid](https://www.infragistics.com/products/ignite-ui-react/react/components/general-getting-started.html) component. |
There was a problem hiding this comment.
NOT the "Filtering Options feature"
| <!-- NOTE: do not change this file because it's auto re-generated from template: --> | ||
| <!-- https://github.com/IgniteUI/igniteui-react-examples/tree/vnext/templates/sample/ReadMe.md --> | ||
|
|
||
| This folder contains implementation of React application with example of Filtering Options feature using [Grid](https://www.infragistics.com/products/ignite-ui-react/react/components/general-getting-started.html) component. |
There was a problem hiding this comment.
NOT the "Filtering Options feature"
| <!-- NOTE: do not change this file because it's auto re-generated from template: --> | ||
| <!-- https://github.com/IgniteUI/igniteui-react-examples/tree/vnext/templates/sample/ReadMe.md --> | ||
|
|
||
| This folder contains implementation of React application with example of Filtering Options feature using [Grid](https://www.infragistics.com/products/ignite-ui-react/react/components/general-getting-started.html) component. |
There was a problem hiding this comment.
NOT the "Filtering Options feature"
| }; | ||
|
|
||
| useEffect(() => { | ||
| fetchData(); // initial load |
There was a problem hiding this comment.
Shouldn't we keep the behaviour consistent here? For example look at this sample for Angular here https://www.infragistics.com/angular-demos/grid/grid-sample-4. A new request is being made on every scroll.
| }; | ||
|
|
||
| useEffect(() => { | ||
| fetchData(); // initial load |
There was a problem hiding this comment.
📌 Putting a pin on this to discuss more about the behaviour.
There was a problem hiding this comment.
I don't think this archived file should be here.
| <!-- NOTE: do not change this file because it's auto re-generated from template: --> | ||
| <!-- https://github.com/IgniteUI/igniteui-react-examples/tree/vnext/templates/sample/ReadMe.md --> | ||
|
|
||
| This folder contains implementation of React application with example of Filtering Options feature using [Grid](https://www.infragistics.com/products/ignite-ui-react/react/components/general-getting-started.html) component. |
2 participants
No description provided.