fix(grid): ensure resize observer is only created if available in ssr - #17498
Open
mddragnev wants to merge 1 commit into
Open
fix(grid): ensure resize observer is only created if available in ssr#17498mddragnev wants to merge 1 commit into
mddragnev wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an SSR-safe guard around ResizeObserver creation in the grid virtualization IgxGridForOfDirective to prevent server-side build/runtime errors when window/ResizeObserver are unavailable.
Changes:
- Avoid unconditional
ResizeObserverinstantiation by checkinggetResizeObserver()before creatingviewObserver. - Ensure SSR environments can initialize the directive without throwing due to missing browser APIs.
Suppressed comments (1)
projects/igniteui-angular/directives/src/directives/for-of/for_of.directive.ts:1683
- This SSR guard changes runtime behavior when
ResizeObserveris missing (e.g., server build or non-DOM environment). Since this directive has an existing Jasmine spec suite, add a unit test that simulateswindow.ResizeObserverbeing unavailable and asserts that initialization does not throw.
const resizeObserver = getResizeObserver();
if (resizeObserver) {
this.viewObserver = new resizeObserver((entries: ResizeObserverEntry[]) => this.viewResizeNotify.next(entries));
}
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
MayaKirova
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17497
Description
Adding a guard that enables creating a resize observer only in browser mode.
Motivation / Context
Type of Change (check all that apply):
Component(s) / Area(s) Affected:
How Has This Been Tested?
Test Configuration:
Screenshots / Recordings
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)