feat(chip): add outlined version - #17485
Open
adrianptrv wants to merge 417 commits into
Open
Conversation
# Conflicts: # package-lock.json # src/app/app.component.html
…put-group - Fix styling issues - Wrapper components (combo, select, date-picker, time-picker,date-range-picker) now forward their @ContentChildren hints to the inner igx-input-group, matching the existing pattern for prefixes and suffixes. This ensures @if (hasHints) works correctly when hints are dynamically added or removed through wrapper components.
…t styles and add active state theming
…height for bundled components
…ton themes - Add `--size` variable for `igx-icon` within buttons for consistent sizing. - Apply `aspect-ratio` to FAB buttons for proper circular appearance.
- fix issues in Material, Indigo, Fluent, and Bootstrap themes for the date-range-picker. - Refactored date-range-picker grid layout for better alignment and flexibility. - Adjusted input group size variables and spacings for consistency across themes.
- Change `box-shadow` to `inset` for consistency in Material, Fluent, Bootstrap, and Indigo themes. - Refactor date-range-picker sample to use dynamic labels and hints. - Update theme variables to use Material palette/schema. - Adjust grid-row layout for better alignment in date-range-picker.
…omponent in favor of global one, update layout styles for samples app. use igx-navbar.
…yles # Conflicts: # projects/igniteui-angular/core/src/core/styles/components/grid/_grid-theme.scss
- Updated Divider, DropDown, and Properties Panel samples to use new layout configurations. - Improved color sample functionality with hex copying and dynamic palette updates. - Refactored Color sample to simplify structure and enhance usability. - Applied scoped styles and updated component themes for consistency. - Resolved layout inconsistencies in Divider and DropDown demos.
…onality - Refactored styling in Indigo, DropDown, Chips, and Grids samples - Removed unused and duplicate properties in date-range-picker sample, simplifying configuration. - Updated date-range-picker sample layout for a cleaner and more streamlined structure.
…simplify sample templates
- Removed `aspect-ratio: 1` from FAB button styles since it courses a visual bug in the samples repo where the buttons that have text + icon become to tall. - Added `width: 100%` to button-group items for better container alignment if the buttongroup itself has display of inline block adn a hardcoded width.
- Updated `themed-block` calls in date-range-picker themes to use correct theme references (Material and Fluent). - Set `--aside-padding` for Fluent theme in demos settings. - Refined styles in `pageHeading` component and updated `igx-input-group` to use `display: block grid`. - Replaced `--_range-border-style` with `--_preview-border-style` in calendar days view styles.
…ge-picker - Adjusted row and column templates for date-range-picker across themes for consistent alignment. - Updated sample structure and styles to enhance readability and showcase use cases. - Simplified SCSS variables and removed redundant styles in input-group and date-picker themes. - Refined HTML and SCSS in samples for improved layout structure and maintainability.
The '.igx-drop-down' panel had no intrinsic width, so once it lost the container width constraint it previously inherited from the global theme, it stretched to fill its nearest block ancestor. 'position: absolute' also restores shrink-to-fit sizing but pulls the panel out of normal flow, which stops it from contributing its height to '.igx-overlay__content' (whose height is otherwise never set explicitly). That broke vertical-flip/positioning math in overlay positioning strategies (regressed IgxAutocomplete top-direction positioning and IgxSimpleCombo's open-upward-when-no-room behavior). 'width: max-content' gives the same shrink-to-fit sizing while keeping the panel in normal flow, so it still drives the overlay content wrapper's auto height correctly.
…i-angular into simeonoff/scoped-styles
adrianptrv
added
styling
❌ status: awaiting-test
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces an outlined styling option for the Chip component, updates chip theme styles (including dark variants), and adds a migration + changelog entry for a breaking theming property rename.
Changes:
- Added
outlinedinput/class support toIgxChipComponentand a unit test validating the applied host class. - Updated Chip theme SCSS across design systems (light + new dark overrides) to support outlined styling and renamed focus shadow theme properties.
- Added a
22.2.0migration (and registration) to renamechip-themeproperties for the focus outline → shadow change, plus updated samples.
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/app/chips/chips.sample.scss | Positions outlined vs non-outlined chip samples in the demo layout. |
| src/app/chips/chips.sample.html | Adds outlined examples for both Angular (igx-chip) and WC (igc-chip) samples. |
| projects/igniteui-angular/migrations/update-22_2_0/index.ts | Registers the 22.2.0 migration rule execution. |
| projects/igniteui-angular/migrations/update-22_2_0/index.spec.ts | Tests the 22.2.0 migration for chip-theme property renames. |
| projects/igniteui-angular/migrations/update-22_2_0/changes/theme-changes.json | Declares the theme property rename mapping for the migration engine. |
| projects/igniteui-angular/migrations/migration-collection.json | Adds migration-59 entry for the 22.2.0 update. |
| projects/igniteui-angular/chips/src/chips/themes/shared/_indigo.scss | Updates focus shadow tokens and adds outlined styling variants for Indigo. |
| projects/igniteui-angular/chips/src/chips/themes/shared/_fluent.scss | Adds outlined styling variants for Fluent (light). |
| projects/igniteui-angular/chips/src/chips/themes/shared/_bootstrap.scss | Updates focus shadow tokens and adds outlined styling variants for Bootstrap (light). |
| projects/igniteui-angular/chips/src/chips/themes/dark/_material.scss | Adds Material dark outlined variant overrides. |
| projects/igniteui-angular/chips/src/chips/themes/dark/_indigo.scss | Adds Indigo dark outlined variants and adjusts disabled handling. |
| projects/igniteui-angular/chips/src/chips/themes/dark/_index.scss | Includes the new dark theme partials for chip (material/bootstrap/fluent). |
| projects/igniteui-angular/chips/src/chips/themes/dark/_fluent.scss | Adds Fluent dark outlined variant overrides. |
| projects/igniteui-angular/chips/src/chips/themes/dark/_bootstrap.scss | Adds Bootstrap dark outlined variant overrides. |
| projects/igniteui-angular/chips/src/chips/themes/_base.scss | Refactors base chip styling to support outlined mode and adjusts borders/disabled states. |
| projects/igniteui-angular/chips/src/chips/chip.spec.ts | Adds a unit test asserting the outlined host class is applied. |
| projects/igniteui-angular/chips/src/chips/chip.component.ts | Adds outlined input with boolean transform and host class binding. |
| CHANGELOG.md | Adds 22.2.0 entries for outlined chip and theming breaking change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes IgniteUI/igniteui-theming#591
Needs to be tested together with this theming PR: #592
The WC implementation: #2307
Description
Type of Change (check all that apply):
Component(s) / Area(s) Affected:
Chip
How Has This Been Tested?
Checklist: