Conversation
rerpha
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a race brought to light by ISISComputingGroup/lewis#336 - that PR subtly changes emulator timing behaviour, in a way our tests should be resilient to. But in this test, we were relying on a
get_valuecompleting quickly enough to see the most recent update, in a brittle way.It's been replaced with the standard
causes_func_to_return_truemachinery to avoid this race.To test this:
python -m pip install git+https://github.com/ISISComputingGroup/lewis@c79836a93d62b93a5a43a3398d664b246e975b31run_tests.bat-test_GIVEN_buffer_almost_full_WHEN_buffer_fills_and_overflows_THEN_correct_readings_returned_1will probably fail