Skip to content

Prevent competing GPT first impressions and resize PUC shells #1079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ChristianPavilonis wants to merge 3 commits into from
Open

Prevent competing GPT first impressions and resize PUC shells #1079

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
002cbf2
Arbitrate GPT first impressions and resize PUC shells
ChristianPavilonis Aug 26, 2026
efcd124
Harden PR 1079 first-impression arbitration (#1083)
prk-Jr Aug 27, 2026
2a79e6a
Address first-impression arbitration review feedback
ChristianPavilonis Aug 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions crates/trusted-server-core/src/integrations/gpt.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1246,12 +1246,16 @@ mod tests {
"should set ts_initial sentinel"
);
assert!(
!combined.contains("addEventListener(\"slotRenderEnded\""),
"inline bootstrap cannot prove TS creative rendering from GPT slotRenderEnded"
combined.contains("addEventListener(\"slotRequested\""),
"should observe publisher GPT requests before delayed adInit"
);
assert!(
combined.contains("addEventListener(\"slotRenderEnded\""),
"should observe publisher GPT renders before delayed adInit"
);
assert!(
!combined.contains("sendBeacon"),
"inline bootstrap must not fire win/billing beacons from GPT slotRenderEnded"
"inline bootstrap lifecycle ownership must not fire win/billing beacons"
);
assert!(
!combined.contains("getTargeting(\"hb_adid\")"),
Expand Down
Loading
Loading