-
Notifications
You must be signed in to change notification settings - Fork 12
Add configuration-driven OpenRTB auction providers #1016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ChristianPavilonis
wants to merge
7
commits into
main
Choose a base branch
from
docs/config-first-auction-provider-spec
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
2b4752a
Document config-first auction provider architecture
ChristianPavilonis ed9210f
Clarify config-first auction provider plan
ChristianPavilonis 943b4ed
Add config-first auction providers
ChristianPavilonis 0a91bd3
Fix generic OpenRTB bidder handling
ChristianPavilonis ba2eea6
Fix post-rebase compatibility
ChristianPavilonis 35e1897
Address config-first provider review feedback
ChristianPavilonis 1e737a8
Normalize Prebid Server provider endpoints
ChristianPavilonis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 praise — Worth calling out, because the diff stat (
+2lines on this file) badly undersells it. This single entry does what breaking-change notes usually omit: it names the retired shape and the replacement shape, walks each moved field to its new owner (server_urltoendpoint, server timeout totimeout_ms, request controls and bidder-parameter overrides toprofile_config, notification suppression tonotifications, each former server bidder to an[auction.bidders.<id>]route), states that removed fields are rejected even when the integration is disabled, and draws the browser-versus-server ownership line for values like timeout and debug that previously did double duty.Most valuable part is the deployment paragraph: stating outright that there is no mixed-version-safe ordering, that old binaries reject the maps while new binaries reject the retired fields, that the binary and config blob must be activated together, and that a rollback needs an old-schema blob restored alongside the old binary. That is the detail an operator actually needs on the day of the migration and the one most often discovered the hard way.