parseChromeResponse results flattening flawed? #85#88
Open
davidcockbill wants to merge 1 commit intoHubSpot:masterfrom
Open
parseChromeResponse results flattening flawed? #85#88davidcockbill wants to merge 1 commit intoHubSpot:masterfrom
davidcockbill wants to merge 1 commit intoHubSpot:masterfrom
Conversation
- Remove flattening of return types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix may be contentious as it changes the existing interface.
I have wondered about different ways of doing this, but the flattening method of removing intermediate response objects (whilst seeming to make sense for trivial stuff) does not hold up in a generic way for more complex returns; especially with multiple optional objects. I also find that it obscures the interface in the documentation.
To that end I have removed the flattening behaviour. So this means that statements like the following:
Now need to add the object tree traversal: