build: entirely use hybris-boot to generate bootimage.#5
Open
peat-psuwit wants to merge 1 commit intoHalium:halium-5.1from
Open
build: entirely use hybris-boot to generate bootimage.#5peat-psuwit wants to merge 1 commit intoHalium:halium-5.1from
peat-psuwit wants to merge 1 commit intoHalium:halium-5.1from
Conversation
This commit remove remaining Ubuntu Touch codes regarding ramdisk and boot image handling, and entirely offload this work to hybris-boot package. With this commit, both bootimage and systemimage can be built successfully for Fairphone 2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit remove remaining Ubuntu Touch codes regarding ramdisk and
boot image handling, and entirely offload this work to hybris-boot
package.
With this commit, both bootimage and systemimage can be built
successfully for Fairphone 2.
Three things to bear in mind:
make bootimagewill producemake recoveryimagewill still produce Android-style recovery boot image as before. (BTW is it working in Halium at all?)This is quite an intrusive change. Test thoroughly on a few different devices before merging this in.