Skip to content

chore: update Node.js from 25 to 26, nightly workflow stays on 26.0.0-nightly#594

Merged
pethers merged 10 commits intomainfrom
copilot/update-node-26-and-next-workflow-27
May 5, 2026
Merged

chore: update Node.js from 25 to 26, nightly workflow stays on 26.0.0-nightly#594
pethers merged 10 commits intomainfrom
copilot/update-node-26-and-next-workflow-27

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 5, 2026

  • Fix CI failure: revert nightly to 26.0.0-nightly
  • docs/End-of-Life-Strategy.md:
    • Fix Node 26 support dates: Bug Fixes Until → Oct 2027, Security Fixes Until → Apr 2029
    • Fix forward-compat note: 26.0.0-nightly (not 27 nightly)
    • Fix completed milestone text: uses 26.0.0-nightly, will switch to 27.0.0-nightly when available
    • Fix Future Node 27 milestone: clarify it's non-LTS, only forward-compat workflow changes
    • Fix version matrix: forward-compat row → "26 nightly (26.0.0-nightly)"
    • Fix TypeScript → 6.0.3, @typescript-eslint → 8.59.2
  • docs/FUTURE_WORKFLOWS.md:
    • Rewrite overview: Node 27 non-LTS; primary workflows/package.json/devcontainer stay on 26 LTS
    • Restructure Phase 1: only test-and-report-latest-node.yml changes (26.0.0-nightly → 27.0.0-nightly)
    • Remove Phase 2 items that incorrectly updated primary workflows to Node 27
    • Update sed commands: Node 27 section has only the nightly switch; Node 28 LTS commands are clearly separated

pethers added 7 commits May 5, 2026 18:38
- Update engines.node in package.json: >=25 -> >=26
- Update devcontainer image: javascript-node:24-trixie -> 26-trixie
- Update devcontainer node feature version: 25 -> 26
- Update all GitHub Actions workflows to use node-version: "26"
  (test-and-report.yml, release.yml, codeql.yml, copilot-setup.yml,
   copilot-setup-steps.yml)
- Update test-and-report-latest-node.yml to node-version: "27-nightly"
- Update docs/End-of-Life-Strategy.md: Node 26 as active, 27 nightly
- Update docs/WORKFLOWS.md: all version references to Node 26/27 nightly
- Update docs/FUTURE_WORKFLOWS.md: rewrite as Node 27 upgrade plan
@github-actions github-actions Bot added documentation Documentation updates dependencies Dependency updates infrastructure CI/CD and build infrastructure security Security improvements devcontainer Development container updates labels May 5, 2026
Copilot finished work on behalf of pethers May 5, 2026 16:50
Copilot AI requested a review from pethers May 5, 2026 16:50
@pethers pethers marked this pull request as ready for review May 5, 2026 16:53
@pethers pethers requested a review from Copilot May 5, 2026 16:53
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 6 comments.

Comment thread docs/WORKFLOWS.md Outdated
| Harden runner | `step-security/harden-runner` (egress-policy: audit) |
| Checkout | `actions/checkout@v6.0.2` |
| Setup Node.js 25 | `actions/setup-node@v6.3.0` with `cache: npm` |
| Setup Node.js 26 | `actions/setup-node@v6.3.0` with `cache: npm` |
Comment thread docs/WORKFLOWS.md
Comment on lines 151 to 154
| Get version | Extracts from tag or input |
| Install system deps | xvfb, Chrome, D-Bus |
| Setup Node.js 25 | `actions/setup-node@v6.3.0` |
| Setup Node.js 26 | `actions/setup-node@v6.3.0` |
| Install + build + test | `npm ci`, `npm run build`, E2E, coverage |
Comment thread docs/WORKFLOWS.md
Comment on lines 163 to 166
| Step | Action |
|------|--------|
| Setup Node.js 25 | `actions/setup-node@v6.3.0` |
| Setup Node.js 26 | `actions/setup-node@v6.3.0` |
| Build | `npm run build` |
Comment thread docs/WORKFLOWS.md Outdated

- [End-of-Life-Strategy.md](./End-of-Life-Strategy.md) — Node.js version lifecycle management
- [FUTURE_WORKFLOWS.md](./FUTURE_WORKFLOWS.md) — Planned Node.js 26 upgrade
- [FUTURE_WORKFLOWS.md](./FUTURE_WORKFLOWS.md) — Node.js 26 upgrade (completed)
Comment thread docs/FUTURE_WORKFLOWS.md Outdated
Comment on lines +123 to +126
|--------|--------------|----------------|
| Node.js 26 Active LTS | October 2026 | Already on 26; no action needed |
| Node.js 27 release | October 2026 | Update primary workflow to 27 |
| Node.js 28 LTS | April 2027 | Next LTS — update `test-and-report-latest-node.yml` to 28 nightly |
Comment thread docs/WORKFLOWS.md Outdated

**Current Node.js version: 25**
**Current Node.js version: 26**
**Current TypeScript version: 6.0.2**
@pethers
Copy link
Copy Markdown
Member

pethers commented May 5, 2026

@copilot apply changes based on the comments in this thread also used correct version for 27 nightly see old pattern for 26

…ersion, and roadmap in docs

Agent-Logs-Url: https://github.com/Hack23/game/sessions/06e31b54-b3d7-467e-8676-4d04b5413444

Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 5, 2026

@copilot apply changes based on the comments in this thread also used correct version for 27 nightly see old pattern for 26

Applied all changes in commit 2c8822f:

  • Nightly version format: "27-nightly""27.0.0-nightly" (matching the old "26.0.0-nightly" pattern, 4 occurrences in test-and-report-latest-node.yml)
  • docs/WORKFLOWS.md: actions/setup-node@v6.3.0v6.4.0 (3 occurrences), TypeScript 6.0.26.0.3, reference label updated to "Node.js 27 upgrade plan (Node.js 26 upgrade completed)"
  • docs/FUTURE_WORKFLOWS.md: Roadmap row for Node.js 27 now correctly states the primary workflow stays on Node.js 26 LTS and only test-and-report-latest-node.yml moves to 27.0.0-nightly; also updated TypeScript/eslint versions and fixed chronological ordering of EOL rows

Copilot finished work on behalf of pethers May 5, 2026 19:40
@pethers pethers requested a review from Copilot May 5, 2026 19:51
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.

Comments suppressed due to low confidence (1)

docs/WORKFLOWS.md:61

  • The workflow step table still documents actions/cache@v5.0.3 for the apt and Cypress caches, but the actual workflows are pinned to actions/cache v5.0.5 (by SHA). Please update these doc entries so they match the versions in .github/workflows/test-and-report*.yml.
| Setup Node.js 26 | `actions/setup-node@v6.4.0` with `cache: npm` |
| Cache apt packages | `actions/cache@v5.0.3` ⚠️ |
| Install system deps | xvfb, libgtk, Chrome dependencies |
| Install dependencies | `npm install` |
| Cache Cypress binary | `actions/cache@v5.0.3` (`~/.cache/Cypress`) |

Comment thread package.json
Comment on lines 19 to 21
"engines": {
"node": ">=25"
"node": ">=26"
},
Comment thread docs/WORKFLOWS.md
**Current Node.js version: 25**
**Current TypeScript version: 6.0.2**
**Current Node.js version: 26**
**Current TypeScript version: 6.0.3**
Comment thread docs/FUTURE_WORKFLOWS.md Outdated
Comment on lines +125 to +126
| Node.js 27 release | October 2026 | Update `test-and-report-latest-node.yml` to 27.0.0-nightly; primary workflow stays on Node.js 26 LTS |
| Node.js 28 LTS | April 2027 | Next LTS — update primary workflow to 28; update `test-and-report-latest-node.yml` to 28 nightly |
Comment thread docs/End-of-Life-Strategy.md Outdated
| Node.js | Release Date | Status | Bug Fixes Until | Security Fixes Until |
|---------|-------------|--------|-----------------|----------------------|
| **25 (Current)** | Oct 15, 2025 | ✅ **Active — in use** | Apr 1, 2026 | Jun 1, 2026 |
| **26 (Current)** | Apr 22, 2026 | ✅ **Active — in use** | Oct 2026 | Oct 2027 |
@pethers
Copy link
Copy Markdown
Member

pethers commented May 5, 2026

@copilot analyse and fix Test and Report Latest Node / prepare (pull_request)
Test and Report Latest Node / prepare (pull_request)Failing after 16sTest and Report Latest Node / prepare (pull_request)
Test and Report Latest Node / prepare (pull_request)Failing after 16s

Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 5, 2026

@copilot analyse and fix Test and Report Latest Node / prepare (pull_request)
Test and Report Latest Node / prepare (...

Fixed in commit b04c378. The CI failure was Unable to find Node version '27.0.0-nightly' — Node.js 27 nightly builds don't exist yet (Node 27 is expected October 2026). Reverted test-and-report-latest-node.yml to "26.0.0-nightly" (4 occurrences), which tests against the latest Node 26 nightly patch builds and keeps the forward-compat workflow green. The docs have been updated to note that this will advance to 27.0.0-nightly once those builds are published.

Copilot AI changed the title chore: update Node.js from 25 to 26, nightly workflow to Node.js 27 chore: update Node.js from 25 to 26, nightly workflow stays on 26.0.0-nightly May 5, 2026
Copilot finished work on behalf of pethers May 5, 2026 20:35
@pethers pethers requested a review from Copilot May 5, 2026 20:40
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 6 comments.

Comment thread docs/End-of-Life-Strategy.md Outdated
Comment on lines 20 to 21
> **Note:** Node.js 26 is an even-numbered release that will graduate to **Active LTS in October 2026**. It was released on April 22, 2026. We use Node.js 27 nightly builds in the forward-compatibility workflow (`test-and-report-latest-node.yml`) to validate readiness for the next release.

Comment on lines +114 to 117
### ✅ CompletedUpgraded to Node.js 26: May 2026

Node.js 25 receives its final bug-fix release around **April 1, 2026**. Security-only patches continue until **June 1, 2026**.
All CI/CD workflows, devcontainer configuration, and `package.json` have been updated to Node.js 26. The forward-compatibility workflow (`test-and-report-latest-node.yml`) now targets Node.js 27 nightly.

Comment on lines 145 to 149
| Workflow | Purpose | Current Node Version |
|----------|---------|----------------------|
| `test-and-report.yml` | Primary CI — stable, production-ready | **25** |
| `test-and-report-latest-node.yml` | Forward-compat — tests next version | **25** (will become 26) |
| `test-and-report.yml` | Primary CI — stable, production-ready | **26** |
| `test-and-report-latest-node.yml` | Forward-compat — tests next version | **27 nightly** |

Comment thread docs/FUTURE_WORKFLOWS.md Outdated
Comment on lines 30 to 34
### Phase 1 — Core Configuration (Day 1)

- [ ] **`package.json`** — Update `engines.node` from `>=25` to `>=26`
- [ ] **`.devcontainer/devcontainer.json`** — Update image from `javascript-node:25-trixie` to `javascript-node:26-trixie`, and node feature version from `"25"` to `"26"`
- [ ] **`package.json`** — Update `engines.node` from `>=26` to `>=27`
- [ ] **`.devcontainer/devcontainer.json`** — Update image from `javascript-node:26-trixie` to `javascript-node:27-trixie`, and node feature version from `"26"` to `"27"`

Comment thread docs/FUTURE_WORKFLOWS.md Outdated
Comment on lines +35 to +44
### Phase 2 — GitHub Actions Workflows (Day 1)

Update `node-version` from `"25"` to `"26"` in each of the following files:
Update `node-version` from `"26"` to `"27"` in each of the following files:

- [ ] **`.github/workflows/test-and-report.yml`** — 4 occurrences (prepare, build-validation, unit-tests, e2e-tests)
- [ ] **`.github/workflows/release.yml`** — 2 occurrences (prepare, build)
- [ ] **`.github/workflows/codeql.yml`** — 1 occurrence (analyze)
- [ ] **`.github/workflows/copilot-setup-steps.yml`** — 1 occurrence
- [ ] **`.github/workflows/copilot-setup.yml`** — 1 occurrence in `node-version`, 1 occurrence in setup report text (`Node.js 25` → `Node.js 26`)
- [ ] **`.github/workflows/test-and-report-latest-node.yml`** — 4 occurrences (update to next version beyond 26, e.g., `"27"` once it exists, or keep at `"26"` until 27 ships)
- [ ] **`.github/workflows/copilot-setup.yml`** — 1 occurrence in `node-version`, 1 occurrence in setup report text (`Node.js 26` → `Node.js 27`)
- [ ] **`.github/workflows/test-and-report-latest-node.yml`** — 4 occurrences (update from `"26.0.0-nightly"` to `"27.0.0-nightly"` once Node.js 27 nightly builds are published; then advance to `"28.0.0-nightly"` once Node.js 28 nightly builds exist)
Comment on lines 157 to 161
| Tool | Current Version | Peer Constraint | Upgrade Path |
|------|----------------|-----------------|--------------|
|------|----------------|-----------------|-------------|
| TypeScript | **6.0.2** | — | Follow quarterly releases |
| @typescript-eslint | **8.58.0** | `typescript >=4.8.4 <6.1.0` | Must update before TS 6.1 |
| Vite | **8.0.3** | — | Follow major releases |
@pethers
Copy link
Copy Markdown
Member

pethers commented May 5, 2026

@copilot apply changes based on the comments in this thread

…WORKFLOWS phases

Agent-Logs-Url: https://github.com/Hack23/game/sessions/ed6b0996-e2c8-4bc8-9bb5-f40234bfb2fe

Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 5, 2026

@copilot apply changes based on the comments in this thread

Applied all changes in commit 5651948:

docs/End-of-Life-Strategy.md:

  • Node 26 support dates corrected: Bug Fixes Until → Oct 2027 (end of Active LTS), Security Fixes Until → Apr 2029 (EOL)
  • Forward-compat note updated to 26.0.0-nightly (not 27 nightly)
  • Completed milestone text now says "currently uses 26.0.0-nightly — will switch to 27.0.0-nightly once builds are published"
  • Future Node 27 milestone: clarified as non-LTS; only test-and-report-latest-node.yml changes
  • Version matrix forward-compat row: "26 nightly (26.0.0-nightly)"
  • TypeScript → 6.0.3, @typescript-eslint8.59.2

docs/FUTURE_WORKFLOWS.md:

  • Overview rewritten: Node 27 is odd/non-LTS; primary workflows, package.json, and devcontainer remain on Node.js 26 LTS
  • Phase 1 now covers only the test-and-report-latest-node.yml nightly switch (26.0.0-nightly27.0.0-nightly)
  • Removed incorrect checklist items that would have migrated primary workflows to Node 27
  • Sed commands section: Node 27 has one command (nightly switch only); Node 28 LTS upgrade commands are clearly separated with a "DO NOT run for Node.js 27" note

Copilot finished work on behalf of pethers May 5, 2026 20:53
@pethers pethers merged commit 19f752a into main May 5, 2026
15 checks passed
@pethers pethers deleted the copilot/update-node-26-and-next-workflow-27 branch May 5, 2026 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Dependency updates devcontainer Development container updates documentation Documentation updates infrastructure CI/CD and build infrastructure security Security improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants