Skip to content

Rework 'Split Vec2' and 'Split Channels' as multi-output nodes and merge 'Position/Tangent on Path' into 'Evaluate Path' - #4645

Merged
Keavon merged 1 commit into
masterfrom
multi-output-catalog-nodes
Oct 7, 2026
Merged

Keavon merged 1 commit into
masterfrom
multi-output-catalog-nodes

Conversation

@Keavon

@Keavon Keavon commented Oct 3, 2026 •

Copy link
Copy Markdown
Member

Retired in favor of replacements:

Extract Channel -> Split Channels
Extract XY -> Split Vec2

Position on Path -> Evaluate Path
Tangent on Path -> Evaluate Path

Replaced by a single node under the same name:

Split Channels
Split Vec2

@Keavon
Keavon requested a review from TrueDoctor as a code owner October 3, 2026 22:04

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 16 files

Confidence score: 3/5

  • adjustments.rs makes existing graphs that extract channels from colors or gradients type-incompatible after migration. Preserve those implementations or route those nodes to a compatible replacement.
Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="node-graph/nodes/raster/src/adjustments.rs">

<violation number="1" location="node-graph/nodes/raster/src/adjustments.rs:158">
P2: This removes the prior `Color` and `Gradient` implementations, but migration redirects every old Extract Channel node to this Raster-only node. Existing graphs extracting channels from colors or gradients become type-incompatible; preserve those implementations or migrate those cases separately.</violation>
</file>

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread editor/src/messages/portfolio/document_migration.rs Outdated
Comment thread node-graph/nodes/math/src/lib.rs
Comment thread node-graph/nodes/raster/src/adjustments.rs
…rge 'Position/Tangent on Path' into 'Evaluate Path'
@Keavon
Keavon force-pushed the multi-output-catalog-nodes branch from 673c7bc to 7b7103c Compare October 7, 2026 18:55
@Keavon
Keavon merged commit 8ef7432 into master Oct 7, 2026
11 checks passed
@Keavon
Keavon deleted the multi-output-catalog-nodes branch October 7, 2026 19:33

This branch was successfully deployed

1 active deployment
graphite-dev (Preview) — 7b7103c1 Deployed Oct 7, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants