Repository navigation
Rework 'Split Vec2' and 'Split Channels' as multi-output nodes and merge 'Position/Tangent on Path' into 'Evaluate Path' - #4645
Merged
Conversation
Contributor
There was a problem hiding this comment.
1 issue found across 16 files
Confidence score: 3/5
adjustments.rsmakes existing graphs that extract channels from colors or gradients type-incompatible after migration. Preserve those implementations or route those nodes to a compatible replacement.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="node-graph/nodes/raster/src/adjustments.rs">
<violation number="1" location="node-graph/nodes/raster/src/adjustments.rs:158">
P2: This removes the prior `Color` and `Gradient` implementations, but migration redirects every old Extract Channel node to this Raster-only node. Existing graphs extracting channels from colors or gradients become type-incompatible; preserve those implementations or migrate those cases separately.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Keavon
added this pull request to stack #4646
October 3, 2026 22:09
Keavon
force-pushed
the
multi-output-catalog-nodes
branch
from
October 4, 2026 08:47
bfd2515 to
e94f081
Compare
Keavon
force-pushed
the
multi-output-catalog-nodes
branch
from
October 7, 2026 00:03
e94f081 to
5d15245
Compare
Keavon
force-pushed
the
multi-output-catalog-nodes
branch
from
October 7, 2026 10:05
5d15245 to
606d882
Compare
Keavon
force-pushed
the
multi-output-catalog-nodes
branch
from
October 7, 2026 10:08
606d882 to
c71b1e4
Compare
TrueDoctor
approved these changes
Oct 7, 2026
Keavon
force-pushed
the
multi-output-catalog-nodes
branch
from
October 7, 2026 18:33
c71b1e4 to
673c7bc
Compare
…rge 'Position/Tangent on Path' into 'Evaluate Path'
Keavon
force-pushed
the
multi-output-catalog-nodes
branch
from
October 7, 2026 18:55
673c7bc to
7b7103c
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retired in favor of replacements:
Extract Channel -> Split Channels
Extract XY -> Split Vec2
Position on Path -> Evaluate Path
Tangent on Path -> Evaluate Path
Replaced by a single node under the same name:
Split Channels
Split Vec2