Skip to content

Make the Pen tool's preview segment follow the cursor during a G/R/S handle transform#4269

Merged
Keavon merged 1 commit into
masterfrom
pen-grs-handle-follow-cursor
Jun 22, 2026
Merged

Make the Pen tool's preview segment follow the cursor during a G/R/S handle transform#4269
Keavon merged 1 commit into
masterfrom
pen-grs-handle-follow-cursor

Conversation

@Keavon

@Keavon Keavon commented Jun 22, 2026

Copy link
Copy Markdown
Member

Closes #4267

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the pen tool's state machine in pen_tool.rs to ensure the preview segment's endpoint tracks the cursor while the outgoing handle is transformed by a GRS operation. This is achieved by calling tool_data.place_anchor before updating the latest point. There are no review comments, and the changes look correct, so I have no further feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@Keavon Keavon merged commit b286e89 into master Jun 22, 2026
10 checks passed
@Keavon Keavon deleted the pen-grs-handle-follow-cursor branch June 22, 2026 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Grab Rotate Scale Handle Mode Requires Seemingly Redundant Confirmation

1 participant