Move Fill/Stroke paint flow to graphic-list values#4257
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the Fill and Stroke nodes to use a modern value-model, introducing the type-erased AnyGraphicListDyn to accept various renderable list types without monomorphization. It updates properties UI, document migration logic, and tests to align with these changes. Feedback on the changes highlights an issue where setting a gradient fill on a previously node-connected input fails to utilize the new value-model because get_fill_node_id_with_value returns None. To resolve this, it is suggested to explicitly set the FillInput to a literal Gradient value at the start of the Fill::Gradient match arm to disconnect any upstream node.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
YohYamasaki
force-pushed
the
use-graphic-list-in-fill-stroke-nodes
branch
from
8fcc653 to
9391c56
Compare
YohYamasaki
force-pushed
the
use-graphic-list-in-fill-stroke-nodes
branch
from
ab229aa to
d84685d
Compare
YohYamasaki
force-pushed
the
use-graphic-list-in-fill-stroke-nodes
branch
from
235f417 to
93582a3
Compare
…crete types Store fill/stroke paints as List<Graphic> so Color/Gradient transitions do not hit set_attribute_value_dyn's type-mismatch fallback to default paint.
YohYamasaki
changed the title
1 participant
WIP