Fix click target metadata not propagating through intermediate wrapper table rows#3967
Merged
Fix click target metadata not propagating through intermediate wrapper table rows#3967
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request modifies the collect_metadata implementation for Table<Graphic> and Table<Vector> to ensure metadata is correctly collected through anonymous wrapper rows and to fix a bug where the footprint transform was incorrectly mutated during iteration. The reviewer suggested simplifying the recursion logic in Table<Graphic> by passing the source_node_id option directly to the recursive call instead of using an if-else block.
Comment on lines
+736
to
741
| if let Some(element_id) = row.source_node_id { | ||
| row.element.collect_metadata(metadata, footprint, Some(*element_id)); | ||
| } else { | ||
| // Recurse through anonymous wrapper rows to reach nested content with source_node_ids | ||
| row.element.collect_metadata(metadata, footprint, None); | ||
| } |
Contributor
There was a problem hiding this comment.
This if-else block can be simplified by directly passing the dereferenced source_node_id. This is equivalent to the current logic and more concise.
// Recurse through anonymous wrapper rows to reach nested content with source_node_ids
row.element.collect_metadata(metadata, footprint, *row.source_node_id);![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the Blend Shapes not being unable to select click targets for its group layer's children:
capture_13_.mp4