Update dependencies to resolve advisories#3933
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a comprehensive update of both Rust and JavaScript dependencies across the project. The primary goal is to resolve existing security advisories and integrate newer, more stable library versions. These updates collectively aim to bolster the project's security posture, improve maintainability, and ensure compatibility with the latest development standards and practices. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates dependencies in Cargo.lock, deny.toml, and frontend/package.json to address security advisories and improve the overall stability of the project. It also adds new dependencies and removes outdated ones in libraries/rawkit/Cargo.lock and updates versions of existing dependencies. The deny.toml file is updated to ignore specific advisories related to unmaintained crates. The frontend/package.json file updates various development dependencies to their latest versions.
| "sass": "^1.97.2", | ||
| "svelte": "5.47.1", | ||
| "sass": "^1.98.0", | ||
| "svelte": "^5.54.1", |
| "RUSTSEC-2024-0388", # Unmaintained `derivative`, used directly by graphite-editor and graphite-desktop | ||
| "RUSTSEC-2024-0436", # Unmaintained `paste`, pulled in by dependencies `metal` and `wgpu-hal` | ||
| "RUSTSEC-2025-0134", # Unmaintained `rustls-pemfile`, pulled in by build dependency `download-cef` | ||
| "RUSTSEC-2025-0141", # Unmaintained `bincode`, pulled in by dev dependency `iai-callgrind` |
There was a problem hiding this comment.
The ignore list is updated with advisories that are marked as unmaintained. It's good to acknowledge these, but consider if there are active alternatives to these dependencies, especially for those used directly (derivative).
While ignoring advisories is sometimes necessary, it's crucial to periodically re-evaluate these ignored advisories to see if they can be addressed through updates or alternative libraries. Ignoring advisories can introduce potential security risks if the vulnerabilities are not mitigated.
| name = "bitflags" | ||
| version = "1.3.2" | ||
| source = "registry+https://github.com/rust-lang/crates.io-index" | ||
| checksum = "bef38d45163c2f1dde094a7dfd33ccf595c92905c8f8f4fdc18d06fb1037718a" | ||
|
|
||
| [[package]] | ||
| name = "bitflags" | ||
| version = "2.9.3" | ||
| source = "registry+https://github.com/rust-lang/crates.io-index" | ||
| checksum = "34efbcccd345379ca2868b2b2c9d3782e9cc58ba87bc7d79d5b53d9c9ae6f25d" | ||
|
|
||
| [[package]] | ||
| name = "bitstream-io" | ||
| version = "2.6.0" | ||
| version = "2.11.0" | ||
| source = "registry+https://github.com/rust-lang/crates.io-index" | ||
| checksum = "6099cdc01846bc367c4e7dd630dc5966dccf36b652fae7a74e17b640411a91b2" | ||
| checksum = "843867be96c8daad0d758b57df9392b6d8d271134fce549de6ce169ff98a92af" |
| name = "bitstream-io" | ||
| version = "4.5.0" | ||
| version = "4.9.0" | ||
| source = "registry+https://github.com/rust-lang/crates.io-index" | ||
| checksum = "b348c85aeb6d0bb7dee47de5506b587d9c6c17856d1314eb4695ad751edc7231" | ||
| checksum = "60d4bd9d1db2c6bdf285e223a7fa369d5ce98ec767dec949c6ca62863ce61757" |
| name = "built" | ||
| version = "0.7.7" | ||
| version = "0.8.0" | ||
| source = "registry+https://github.com/rust-lang/crates.io-index" | ||
| checksum = "56ed6191a7e78c36abdb16ab65341eefd73d64d303fffccdbb00d51e4205967b" | ||
| checksum = "f4ad8f11f288f48ca24471bbd51ac257aaeaaa07adae295591266b792902ae64" |
| ] | ||
|
|
||
| [[package]] | ||
| name = "built" |
| version = "0.25.10" | ||
| source = "registry+https://github.com/rust-lang/crates.io-index" | ||
| checksum = "db35664ce6b9810857a38a906215e75a9c879f0696556a39f59c62829710251a" | ||
| checksum = "85ab80394333c02fe689eaf900ab500fbd0c2213da414687ebf995a65d5a6104" |
| @@ -1395,14 +1490,14 @@ dependencies = [ | |||
| name = "rawkit" | |||
| [[package]] | ||
| name = "reqwest" | ||
| version = "0.12.23" | ||
| version = "0.13.2" |
| "percent-encoding", | ||
| "pin-project-lite", | ||
| "quinn", | ||
| "rustls", |
No description provided.