sql: Add enhanced_query_insights_enabled to insights_config

[zjalicf]

Adds support for the enhancedQueryInsightsEnabled API field in google_sql_database_instance.settings.insights_config.

This field enables the Query Insights Enhanced feature for Enterprise Plus instances. Currently, it is not possible to change this field via terraform, but it is available in REST API doc:

Fixes: hashicorp/terraform-provider-google#22281

sql: added `enhanced_query_insights_enabled` field to `google_sql_database_instance` resource `insights_config` block

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@malhotrasagar2212, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[zjalicf]

Looks like github worklow uses old go client. This was added only 3 weeks ago:

https://github.com/googleapis/google-api-go-client/blame/29bd84381608db3db0385bd8f4544af458df7329/sqladmin/v1beta4/sqladmin-gen.go#L3068

not sure what is the best way forward here, other than updating CI/CD

[SirGitsalot]

FYI #16270

[github-actions]

@malhotrasagar2212 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions]

@GoogleCloudPlatform/terraform-team @malhotrasagar2212 This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 20 insertions(+), 10 deletions(-))
google-beta provider: Diff ( 2 files changed, 20 insertions(+), 10 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_sql_database_instance (233 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_sql_database_instance" "primary" {
  settings {
    insights_config {
      enhanced_query_insights_enabled = # value needed
      query_insights_enabled          = # value needed
      query_plans_per_minute          = # value needed
      query_string_length             = # value needed
      record_application_tags         = # value needed
      record_client_address           = # value needed
    }
  }
}

Missing doc report (experimental)

The following resources have fields missing in documents.

• google_sql_database_instance
  • Expected Document Path: /website/docs/r/sql_database_instance.html.markdown
  • Fields: [settings.insights_config.enhanced_query_insights_enabled]

[modular-magician]

Tests analytics

Total tests: 143
Passed tests: 116
Skipped tests: 27
Affected tests: 0

Click here to see the affected service packages

• sql

🟢 All tests passed!

View the build log

[github-actions]

@GoogleCloudPlatform/terraform-team @malhotrasagar2212 This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

[malhotrasagar2212]

@zjalicf Please check the failures, Thanks.

[github-actions]

@zjalicf, this PR is waiting for action from you. If no action is taken, this PR will be closed in 28 days.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

This notification can be disabled with the disable-automatic-closure label.

[github-actions]

@zjalicf, this PR is waiting for action from you. If no action is taken, this PR will be closed in 28 days.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

This notification can be disabled with the disable-automatic-closure label.

[github-actions]

@zjalicf, this PR is waiting for action from you. If no action is taken, this PR will be closed in 14 days.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

This notification can be disabled with the disable-automatic-closure label.

[github-actions]

@zjalicf, this PR is waiting for action from you. If no action is taken, this PR will be closed in 2 weekdays.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

This notification can be disabled with the disable-automatic-closure label.

[github-actions]

@zjalicf, this PR is being closed due to inactivity.