Skip to content

Remove exactly_one_of for restriction for ssl_certificates and certificate_map#16272

Merged
melinath merged 1 commit intoGoogleCloudPlatform:mainfrom
pawelJas:ssl-certificate-with-certificate-map
Feb 5, 2026
Merged

Remove exactly_one_of for restriction for ssl_certificates and certificate_map#16272
melinath merged 1 commit intoGoogleCloudPlatform:mainfrom
pawelJas:ssl-certificate-with-certificate-map

Conversation

@pawelJas
Copy link
Copy Markdown
Contributor

@pawelJas pawelJas commented Feb 2, 2026

Remove exactly_one_of for restriction for ssl_certificates and certificate_map

Fixes: hashicorp/terraform-provider-google#25835

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: allows to set both ssl_certificates and certificate_map in target_ssl_proxy

@github-actions github-actions Bot requested a review from melinath February 2, 2026 14:34
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 2, 2026

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 12 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 3 files changed, 12 insertions(+), 2 deletions(-))
Open in Cloud Shell: Diff ( 1 file changed, 6 insertions(+))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 1330
Passed tests: 1243
Skipped tests: 86
Affected tests: 1

Click here to see the affected service packages
  • compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeTargetSslProxy_targetSslProxyBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccComputeTargetSslProxy_targetSslProxyBasicExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 5, 2026

@melinath This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link
Copy Markdown
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks straightforward; test was modified and passed.

@melinath melinath enabled auto-merge February 5, 2026 21:52
@melinath melinath disabled auto-merge February 5, 2026 21:57
@melinath melinath enabled auto-merge February 5, 2026 21:57
@melinath melinath disabled auto-merge February 5, 2026 23:06
@melinath melinath added this pull request to the merge queue Feb 5, 2026
Merged via the queue into GoogleCloudPlatform:main with commit 779ca2c Feb 5, 2026
27 of 29 checks passed
18811376770 pushed a commit to 18811376770/magic-modules that referenced this pull request Feb 11, 2026
JianweiQ pushed a commit to JianweiQ/magic-modules that referenced this pull request Feb 20, 2026
kefang2 pushed a commit to kefang2/magic-modules that referenced this pull request Feb 28, 2026
aditikumarii-google pushed a commit to aditikumarii-google/magic-modules that referenced this pull request Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

google_compute_target_ssl_proxy should alow both certificate_map and ssl_certificates

3 participants